-
Notifications
You must be signed in to change notification settings - Fork 136
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: automate creation of GitHub releases and tags #475
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I added some draft text for updating the release process in the README.
That said, I'm wondering if we can have the asset creation/attaching happen before the PR gets merged that way someone can see the assets before merging the PR.
@BigLep In other repos, we can; here, the current instructions don't mention anything about asset creation or upload. |
Yeah, I know the instructions don't mention anything about asset creation (doh - bummer). But from looking at https://github.com/filecoin-project/filecoin-ffi/blob/master/.github/workflows/ci.yml#L152 , doesn't it happen on a tag? I'm wondering if we can adjust the triggering conditions and get it into the instructions. |
2024-08-01 conversation with IPDX/FilOz: @galargh will assess week of 2024-08-05 to see if asset creation can be executed in the proposed flow or whether needs separate dedicated work task. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Things look good to me once we have the README correct about the new reality.
The release process and possible improvements for the future were now described in a9cacd9. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have the same RELEASE.md questions/comments as had in filecoin-project/builtin-actors#1571 (review) . Otherwise it looks good to me.
Co-authored-by: Steve Loeppky <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I added a couple of suggestions that had from filecoin-project/builtin-actors#1571
I'm going to commit those and then merge as had verbal during 2024-08-14 Lotus maintainers call where @Stebalien said these changes are good given we don't have to do crate publishing.
Thank you for all the reviews, and help getting it merged 🙇 |
Follow up to #473 (comment)