Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: automate creation of GitHub releases and tags #475

Merged
merged 8 commits into from
Aug 19, 2024

Conversation

galargh
Copy link
Contributor

@galargh galargh commented Jul 24, 2024

Follow up to #473 (comment)

Copy link
Member

@BigLep BigLep left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added some draft text for updating the release process in the README.

That said, I'm wondering if we can have the asset creation/attaching happen before the PR gets merged that way someone can see the assets before merging the PR.

@galargh
Copy link
Contributor Author

galargh commented Jul 25, 2024

@BigLep In other repos, we can; here, the current instructions don't mention anything about asset creation or upload.

@BigLep
Copy link
Member

BigLep commented Jul 25, 2024

@BigLep In other repos, we can; here, the current instructions don't mention anything about asset creation or upload.

Yeah, I know the instructions don't mention anything about asset creation (doh - bummer). But from looking at https://github.com/filecoin-project/filecoin-ffi/blob/master/.github/workflows/ci.yml#L152 , doesn't it happen on a tag? I'm wondering if we can adjust the triggering conditions and get it into the instructions.

@BigLep
Copy link
Member

BigLep commented Aug 1, 2024

2024-08-01 conversation with IPDX/FilOz: @galargh will assess week of 2024-08-05 to see if asset creation can be executed in the proposed flow or whether needs separate dedicated work task.

@galargh
Copy link
Contributor Author

galargh commented Aug 5, 2024

2024-08-01 conversation with IPDX/FilOz: @galargh will assess week of 2024-08-05 to see if asset creation can be executed in the proposed flow or whether needs separate dedicated work task.

Done in dd6b34e 💪

README.md Outdated Show resolved Hide resolved
Copy link
Member

@BigLep BigLep left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Things look good to me once we have the README correct about the new reality.

@galargh
Copy link
Contributor Author

galargh commented Aug 13, 2024

The release process and possible improvements for the future were now described in a9cacd9.

Copy link
Member

@BigLep BigLep left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have the same RELEASE.md questions/comments as had in filecoin-project/builtin-actors#1571 (review) . Otherwise it looks good to me.

RELEASE.md Outdated Show resolved Hide resolved
Copy link
Member

@BigLep BigLep left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added a couple of suggestions that had from filecoin-project/builtin-actors#1571

I'm going to commit those and then merge as had verbal during 2024-08-14 Lotus maintainers call where @Stebalien said these changes are good given we don't have to do crate publishing.

RELEASE.md Outdated Show resolved Hide resolved
RELEASE.md Outdated Show resolved Hide resolved
@BigLep BigLep merged commit a6368b9 into master Aug 19, 2024
5 checks passed
@BigLep BigLep deleted the ipdx/release-automation-v2 branch August 19, 2024 18:02
@galargh
Copy link
Contributor Author

galargh commented Aug 23, 2024

Thank you for all the reviews, and help getting it merged 🙇

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants