Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Google Analytics Fix #46

Merged
merged 2 commits into from
Dec 5, 2023
Merged

Conversation

howardbaik
Copy link
Contributor

@howardbaik howardbaik commented Nov 30, 2023

The problem was that Google Analytics wasn't tracking this course. I looked at the source code for other courses and saw that GA_Script.Rhtml was written in other places. I moved the GA_Script.Rhtml to before_body: [GA_Script.Rhtml, assets/big-image-itcr.html] inside _output.yml

issue #45

Copy link
Contributor

github-actions bot commented Nov 30, 2023

No broken urls! 🎉
Comment updated at 2023-11-30 with changes from edde918

Copy link
Contributor

github-actions bot commented Nov 30, 2023

No spelling errors! 🎉
Comment updated at 2023-11-30 with changes from edde918

Copy link
Contributor

Re-rendered previews from the latest commit:

Updated at 2023-11-30 with changes from edde918

@carriewright11
Copy link
Contributor

carriewright11 commented Dec 5, 2023

for context the previous typical location (using header_includes- see PR #42) was not rendering for me - and I got an error, which is why I moved it :)

Thanks for doing this!

@carriewright11 carriewright11 merged commit 961bfff into main Dec 5, 2023
7 checks passed
@carriewright11 carriewright11 deleted the howardbaek/google-analytics-fix branch December 5, 2023 04:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants