Replace RocksDB by LMDB #6
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Removed RocksDB from Cargo.toml and database module. * Added `heed` crate to Cargo.toml. * Reimplemented all the database API to make use of LMDB over tokio blocking tasks. * Fixed potential key calculation bug. * Added documentation. * Refactored `Database::chunk_exists` to directly load the queried chunk into cache if it exists. * Refactored `Database::batch_insert` to avoid querying database for loading into cache chunks the function already have allocated.
|
Build fails but that's cos of a broken discord webhook, code looks fine. |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For more information: #5
Initially, MDBX was considered for implementation over LMDB, but the API of the reference bindings underwent significant changes and support began to decline. As a result, I opted to implement LMDB instead, which benefits from extensive support in Rust libraries.
heedcrate to Cargo.toml.Database::chunk_existsto directly load the queried chunk into the cache if it exists.Database::batch_insertto avoid querying the database for loading chunks into the cache that the function has already * allocated.Internal logic changes are denoted by
// WARNING:comments.