Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Block SyncAdapter.onPerformSync() until the javascript task is executed #14

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

nvlbg
Copy link
Contributor

@nvlbg nvlbg commented Mar 26, 2018

Block the sync if the task is user visible.

This way when a manual sync is requested from account settings, an
indication that the sync is still happening will be shown to the user,
thus making a better user experience.

if the task is user visible.

This way when a manual sync is requested from the settings, an
indication that the sync is still happening will be shown to the user,
thus making a better user experience.
@ferrannp
Copy link
Owner

ferrannp commented Oct 2, 2018

@nvlbg could you explain this one a bit? I am not exactly sure what this is doing. Maybe you can illustrate it? (GIF) ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants