manifest: Improve error messages for invalid component IDs

Signed-off-by: Lann Martin <[email protected]>

crates/manifest/src/schema/v2.rs

@@ -70,14 +70,28 @@ pub struct OneOrManyComponentSpecs(#[serde(with = "one_or_many")] pub Vec<Compon
 
 /// Component reference or inline definition
 #[derive(Clone, Debug, Serialize, Deserialize)]
-#[serde(deny_unknown_fields, untagged)]
+#[serde(deny_unknown_fields, untagged, try_from = "toml::Value")]
 pub enum ComponentSpec {
     /// `"component-id"`
     Reference(KebabId),
     /// `{ ... }`
     Inline(Box<Component>),
 }
 
+impl TryFrom<toml::Value> for ComponentSpec {
+    type Error = toml::de::Error;
+
+    fn try_from(value: toml::Value) -> Result<Self, Self::Error> {
+        if value.is_str() {
+            Ok(ComponentSpec::Reference(KebabId::deserialize(value)?))
+        } else {
+            Ok(ComponentSpec::Inline(Box::new(Component::deserialize(
+                value,
+            )?)))
+        }
+    }
+}
+
 /// Component definition
 #[derive(Clone, Debug, Serialize, Deserialize)]
 #[serde(deny_unknown_fields)]

crates/manifest/tests/ui/invalid/bad_kebab_component_ref.err

@@ -0,0 +1,6 @@
+TOML parse error at line 7, column 13
+  |
+7 | component = "1-2-3"
+  |             ^^^^^^^
+'-'-separated words must start with an ASCII letter; got '1'
+

crates/manifest/tests/ui/invalid/bad_kebab_component_ref.toml

@@ -0,0 +1,7 @@
+spin_manifest_version = 2
+
+[application]
+name = "minimal-v2"
+
+[[trigger.fake]]
+component = "1-2-3"