Skip to content

Commit

Permalink
fix kv app ci and update README (#32)
Browse files Browse the repository at this point in the history
* fix kv app ci and update README

Signed-off-by: Rajat Jindal <[email protected]>

* dont run on forks

Signed-off-by: Rajat Jindal <[email protected]>

---------

Signed-off-by: Rajat Jindal <[email protected]>
  • Loading branch information
rajatjindal authored Apr 26, 2023
1 parent 571bb0a commit d027f52
Show file tree
Hide file tree
Showing 6 changed files with 11 additions and 14 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/e2e-spin-deploy.yml
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ on:
jobs:
build:
runs-on: ubuntu-latest
if: ${{ github.repository_owner == 'fermyon' }}
if: ${{ !github.event.pull_request.head.repo.fork }}
steps:
- uses: actions/checkout@v3

Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/e2e-spin-preview.yml
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ on:
jobs:
build:
runs-on: ubuntu-latest
if: ${{ github.repository_owner == 'fermyon' }}
if: ${{ !github.event.pull_request.head.repo.fork }}
steps:
- uses: actions/checkout@v3

Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/e2e-spin-push.yml
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ env:
jobs:
build:
runs-on: ubuntu-latest
if: ${{ github.repository_owner == 'fermyon' }}
if: ${{ !github.event.pull_request.head.repo.fork }}
steps:
- uses: actions/checkout@v3

Expand Down
4 changes: 0 additions & 4 deletions .github/workflows/e2e-spin-setup.yml
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,6 @@ jobs:
setup-default-spin:
needs: build
runs-on: ${{ matrix.os }}
if: ${{ github.repository_owner == 'fermyon' }}
strategy:
matrix:
os: [ubuntu-latest, macos-latest, windows-latest]
Expand All @@ -57,7 +56,6 @@ jobs:
setup-specific-spin-version:
needs: build
runs-on: ${{ matrix.os }}
if: ${{ github.repository_owner == 'fermyon' }}
strategy:
matrix:
os: [ubuntu-latest, macos-latest, windows-latest]
Expand Down Expand Up @@ -89,7 +87,6 @@ jobs:
setup-spin-and-one-plugin:
needs: build
runs-on: ${{ matrix.os }}
if: ${{ github.repository_owner == 'fermyon' }}
strategy:
matrix:
os: [ubuntu-latest, macos-latest, windows-latest]
Expand All @@ -115,7 +112,6 @@ jobs:
setup-spin-and-multiple-plugins:
needs: build
runs-on: ${{ matrix.os }}
if: ${{ github.repository_owner == 'fermyon' }}
strategy:
matrix:
os: [ubuntu-latest, macos-latest, windows-latest]
Expand Down
14 changes: 7 additions & 7 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -196,13 +196,13 @@ If you don't run the preview action with undeploy on the closed event, your prev

### Inputs

| Name | Required | Default | Description |
| ------------- | -------- | --------- | ------------------------------------------------------------------------------------------------------------------------------------------------------------------------------ |
| fermyon_token | True | - | Fermyon Cloud Personal Access Token for deploying the Spin app to Fermyon Cloud |
| manifest_file | False | spin.toml | Path to `spin.toml`. |
| github_token | True | - | The GitHub token for adding a comment on PR with preview URL. |
| undeploy | False | - | If true, removes the preview deployment from Fermyon Cloud |
| key_values | False | - | Pass a key/value (key=value) to all components of the application. You can specify multiple key_values by putting each key/value pair on its own line. Refer to example below. |
| Name | Required | Default | Description |
| ------------- | -------- | --------- | ------------------------------------------------------------------------------- |
| fermyon_token | True | - | Fermyon Cloud Personal Access Token for deploying the Spin app to Fermyon Cloud |
| manifest_file | False | spin.toml | Path to `spin.toml`. |
| github_token | True | - | The GitHub token for adding a comment on PR with preview URL. |
| undeploy | False | - | If true, removes the preview deployment from Fermyon Cloud |
| key_values | False | - | Pass one or more key/value pairs to the default store for all components" |

### Example

Expand Down
1 change: 1 addition & 0 deletions example-app/spin.toml
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@ version = "0.1.0"
id = "example-app"
source = "target/spin-http-js.wasm"
exclude_files = ["**/node_modules"]
key_value_stores = ["default"]
[component.trigger]
route = "/..."
[component.build]
Expand Down

0 comments on commit d027f52

Please sign in to comment.