Added Prettier and ESLint to Github Action and re-executed lint #70
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
Someone is attempting to deploy a commit to a Personal Account owned by @ferminrp on Vercel. @ferminrp first needs to authorize it. |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
ferminrp
reviewed
Feb 26, 2024
santigandolfo
commented
Feb 26, 2024
There was a problem hiding this comment.
Creo que dado que ya estamos haciendo varios arreglos de formato, podría ser el momento para que unifiquemos todas las reglas de prettier y biome, y de paso veamos si podemos hacer cambios en algunas.
En mi opinión pondría estas de Biome (y si equivalente de Prettier):
"enabled": true,
"quoteStyle": "double",
"jsxQuoteStyle": "double",
"quoteProperties": "asNeeded",
"trailingComma": "all",
"semicolons": "always",
"arrowParentheses": "always",
"indentStyle": "space",
"indentWidth": 2,
"lineEnding": "lf",
"lineWidth": 80,
"bracketSameLine": false,
"bracketSpacing": true
(obviamente no pondría todas, solo las que difieren de su valor por default)
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.