Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(image): JSDoc Annotations Update #54

Merged
merged 3 commits into from
Sep 26, 2023

Conversation

tooooo1
Copy link
Member

@tooooo1 tooooo1 commented Sep 26, 2023

Summary

  • Updated JSDoc annotations across various functions and components within the image library.

AS-IS
스크린샷 2023-09-26 오후 5 04 20

TO-BE
스크린샷 2023-09-26 오후 5 14 21

Checks

Please check the following:

  • I have written documents and tests, if needed.

@tooooo1 tooooo1 self-assigned this Sep 26, 2023
@tooooo1 tooooo1 requested a review from manudeli as a code owner September 26, 2023 08:14
@changeset-bot
Copy link

changeset-bot bot commented Sep 26, 2023

🦋 Changeset detected

Latest commit: 770e98b

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
@fepack/image Patch
@fepack/react-image Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@netlify
Copy link

netlify bot commented Sep 26, 2023

Deploy Preview for fepack ready!

Name Link
🔨 Latest commit 49849e0
🔍 Latest deploy log https://app.netlify.com/sites/fepack/deploys/651292feaef863000896faea
😎 Deploy Preview https://deploy-preview-54--fepack.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@tooooo1 tooooo1 enabled auto-merge (squash) September 26, 2023 08:15
@netlify
Copy link

netlify bot commented Sep 26, 2023

Deploy Preview for fepack ready!

Name Link
🔨 Latest commit 770e98b
🔍 Latest deploy log https://app.netlify.com/sites/fepack/deploys/6512930fb7c5d500083f115c
😎 Deploy Preview https://deploy-preview-54--fepack.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@codecov
Copy link

codecov bot commented Sep 26, 2023

Codecov Report

Merging #54 (770e98b) into main (7fd6111) will decrease coverage by 0.58%.
The diff coverage is 100.00%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main      #54      +/-   ##
==========================================
- Coverage   56.57%   56.00%   -0.58%     
==========================================
  Files           5        5              
  Lines          76       75       -1     
  Branches       11       11              
==========================================
- Hits           43       42       -1     
  Misses         27       27              
  Partials        6        6              
Components Coverage Δ
@fepack/image 56.00% <100.00%> (-0.58%) ⬇️

@tooooo1 tooooo1 merged commit 3aa772e into main Sep 26, 2023
11 checks passed
@tooooo1 tooooo1 deleted the refactor/jsdoc-updates-for-image branch September 26, 2023 09:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants