Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci(eslint): add eslint-plugin-jsdoc #53

Merged
merged 2 commits into from
Sep 25, 2023
Merged

ci(eslint): add eslint-plugin-jsdoc #53

merged 2 commits into from
Sep 25, 2023

Conversation

manudeli
Copy link
Collaborator

@manudeli manudeli commented Sep 25, 2023

Summary

I added eslint-plugin-jsdoc
This will help us make conventional and sustainable jsdoc comment

Checks

Please check the following:

  • I have written documents and tests, if needed.

@manudeli manudeli self-assigned this Sep 25, 2023
@changeset-bot
Copy link

changeset-bot bot commented Sep 25, 2023

⚠️ No Changeset found

Latest commit: 6e544b5

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@netlify
Copy link

netlify bot commented Sep 25, 2023

Deploy Preview for fepack ready!

Name Link
🔨 Latest commit 6e544b5
🔍 Latest deploy log https://app.netlify.com/sites/fepack/deploys/6511f36e30621700089c31c7
😎 Deploy Preview https://deploy-preview-53--fepack.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@codecov
Copy link

codecov bot commented Sep 25, 2023

Codecov Report

Merging #53 (6e544b5) into main (76feea2) will not change coverage.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main      #53   +/-   ##
=======================================
  Coverage   56.57%   56.57%           
=======================================
  Files           5        5           
  Lines          76       76           
  Branches       11       11           
=======================================
  Hits           43       43           
  Misses         27       27           
  Partials        6        6           
Components Coverage Δ
@fepack/image 56.57% <ø> (ø)

@manudeli manudeli marked this pull request as ready for review September 25, 2023 20:44
@manudeli manudeli requested a review from tooooo1 as a code owner September 25, 2023 20:44
@tooooo1 tooooo1 merged commit 7fd6111 into main Sep 25, 2023
11 checks passed
@tooooo1 tooooo1 deleted the chore/jsdoc-eslint branch September 25, 2023 21:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants