Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(image): change extractColors to extractRGBAs #42

Merged
merged 1 commit into from
Sep 24, 2023

Conversation

manudeli
Copy link
Collaborator

@manudeli manudeli commented Sep 24, 2023

Summary

I changed extractColors to extractRGBAs

Checks

Please check the following:

  • I have written documents and tests, if needed.

@changeset-bot
Copy link

changeset-bot bot commented Sep 24, 2023

⚠️ No Changeset found

Latest commit: 0231b22

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@manudeli manudeli self-assigned this Sep 24, 2023
@manudeli manudeli marked this pull request as ready for review September 24, 2023 17:29
@manudeli manudeli requested a review from tooooo1 as a code owner September 24, 2023 17:29
@codecov
Copy link

codecov bot commented Sep 24, 2023

Codecov Report

Merging #42 (0231b22) into feat/color-extractor (d29136d) will decrease coverage by 0.90%.
The diff coverage is 90.90%.

Additional details and impacted files

Impacted file tree graph

@@                   Coverage Diff                    @@
##           feat/color-extractor      #42      +/-   ##
========================================================
- Coverage                 96.55%   95.65%   -0.90%     
========================================================
  Files                         4        4              
  Lines                        58       46      -12     
  Branches                      9        6       -3     
========================================================
- Hits                         56       44      -12     
  Misses                        2        2              
Components Coverage Δ
@fepack/image 95.65% <90.90%> (-0.90%) ⬇️

@tooooo1 tooooo1 merged commit fab95ee into feat/color-extractor Sep 24, 2023
8 checks passed
@tooooo1 tooooo1 deleted the feat/suggestion branch September 24, 2023 17:30
@manudeli manudeli mentioned this pull request Sep 24, 2023
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants