Fix type error; Sanitizer::validateEmail() should return bool

femiwiki · Sep 21, 2024 · b6e7ef3 · b6e7ef3
1 parent cb1b7e0
commit b6e7ef3
Showing 1 changed file with 2 additions and 0 deletions.
diff --git a/includes/HookHandlers/SpamEmail.php b/includes/HookHandlers/SpamEmail.php
@@ -58,6 +58,7 @@ public function onIsValidEmailAddr( $addr, &$result ) {
 			$match = preg_match( $regex, $addr );
 			AtEase::restoreWarnings();
 			if ( $match ) {
+				$result = false;
 				return false;
 			}
 		}
@@ -74,6 +75,7 @@ static function ( $block ) {
 			$this->databaseBlockStore->newListFromConds( [] )
 		) ) );
 		if ( in_array( $addr, $emails ) ) {
+			$result = false;
 			return false;
 		}
 	}