Adding optional clipping to tippecanoe-overzoom #298
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
e-n-f
requested review from
migurski,
arredond,
dnomadb and
ChrisLoer
as code owners
e-n-f
commented
Nov 27, 2024
overzoom.cpp
Outdated
| @@ -67,7 +69,10 @@ int main(int argc, char **argv) { | |||
| {"assign-to-bins", required_argument, 0, 'b' & 0x1F}, | |||
| {"bin-by-id-list", required_argument, 0, 'c' & 0x1F}, | |||
| {"accumulate-numeric-attributes", required_argument, 0, 'a' & 0x1F}, | |||
| {"numeric-attributes", required_argument, 0, 'a' & 0x1F}, | |||
There was a problem hiding this comment.
This looks like a merge conflict accidental edit
e-n-f
commented
Nov 27, 2024
| } | ||
|
|
||
| case 'l' & 0x1F: { | ||
| clipbbox clip = parse_clip_poly(optarg); |
There was a problem hiding this comment.
Clip the clip regions to the tile bounds to speed up the case where complicate bounds entirely enclose the tile.
ChrisLoer
approved these changes
Nov 27, 2024
ChrisLoer
approved these changes
Nov 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds
--clip-bounding-boxand--clip-polygonoptions totippecanoe-overzoom, to clip the output tile to arbitrary rectangular or polygon bounds.To accomplish LineString clipping to polygon bounds, it brings back Clipper as a vendored package. Wagyu continues to be used to clip and clean polygons.