Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Only detect longitude wraparound within each ring. #150

Merged
merged 3 commits into from
Oct 17, 2023
Merged

Only detect longitude wraparound within each ring. #150

merged 3 commits into from
Oct 17, 2023

Conversation

e-n-f
Copy link
Collaborator

@e-n-f e-n-f commented Oct 6, 2023 •
edited
Loading

Between rings it's OK to jump around from one side of the world to the other.

Natural Earth bathymetry contour 6000 before and after:

Screenshot 2023-10-06 at 12 51 21 PM Screenshot 2023-10-06 at 12 51 24 PM

e-n-f added 2 commits October 6, 2023 12:32
@e-n-f
Only detect longitude wraparound within each ring.
4d423c6 
Between rings it's OK to jump around from one side of the world
to the other.
@e-n-f
Add test
23227ec
@e-n-f e-n-f marked this pull request as ready for review October 6, 2023 20:10
joeherm
joeherm approved these changes Oct 6, 2023
View reviewed changes
Copy link

@joeherm joeherm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@e-n-f e-n-f merged commit e1c665b into main Oct 17, 2023
1 check passed
@e-n-f e-n-f deleted the fix-detect-wraparound branch October 17, 2023 19:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joeherm joeherm joeherm approved these changes

@migurski migurski Awaiting requested review from migurski migurski is a code owner

@arredond arredond Awaiting requested review from arredond arredond is a code owner

@dnomadb dnomadb Awaiting requested review from dnomadb dnomadb is a code owner

@ChrisLoer ChrisLoer Awaiting requested review from ChrisLoer ChrisLoer is a code owner

@ibesora ibesora Awaiting requested review from ibesora

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@e-n-f @joeherm