Fix out of bounds memory access below, apparently

felt · Oct 2, 2023 · 30087b2 · 30087b2
1 parent a568e78
commit 30087b2
Showing 1 changed file with 1 addition and 2 deletions.
diff --git a/serial.cpp b/serial.cpp
@@ -499,14 +499,13 @@ int serialize_feature(struct serialization_state *sst, serial_feature &sf) {
 		}
 	}
 
+	scaled_geometry = remove_noop(scaled_geometry, sf.t, 0);
 	if (scaled_geometry.size() == 0) {
 		// Feature was clipped away
 		return 1;
 	}
 
 	if (prevent[P_SIMPLIFY_SHARED_NODES]) {
-		scaled_geometry = remove_noop(scaled_geometry, sf.t, 0);
-
 		if (sf.t == VT_POLYGON || sf.t == VT_LINE) {
 			for (size_t i = 0; i < scaled_geometry.size(); i++) {
 				if (scaled_geometry[i].op == VT_MOVETO) {