Skip to content

Commit

Permalink
Take out build_path template until it works
Browse files Browse the repository at this point in the history
Since it is breaking the docker container, take out the build path value
until we can fix the templating engine to work with all of the javascript
files.

Possibly related to issue #130
  • Loading branch information
kruton committed Feb 5, 2022
1 parent 6537b1c commit eb80db1
Show file tree
Hide file tree
Showing 3 changed files with 2 additions and 6 deletions.
2 changes: 1 addition & 1 deletion Dockerfile
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ COPY static/package*.json ./
COPY static/src ./src
COPY static/public ./public
RUN npm install
RUN PUBLIC_URL=/{{build_path}} npm run build
RUN PUBLIC_URL=/build npm run build

FROM python:3.9.5-alpine3.12
WORKDIR /tmp
Expand Down
2 changes: 1 addition & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@ If you are planning on solely developing for the backend, you can build a static

```
cd static
PUBLIC_URL=/{{build_path}} npm run build
PUBLIC_URL=/build npm run build
```

Otherwise, in a different shell, run the Webpack development server:
Expand Down
4 changes: 0 additions & 4 deletions feeder/main.py
Original file line number Diff line number Diff line change
Expand Up @@ -33,14 +33,10 @@ async def render_frontend(full_path: str, request: Request):
raise HTTPException(status_code=404)

if frontend.exists():
build_path = "build"
if settings.app_root:
build_path = f"{settings.app_root[1:]}/build"
return frontend_template.TemplateResponse(
"index.html",
{
"request": request,
"build_path": build_path,
"root_path": settings.app_root,
},
)
Expand Down

0 comments on commit eb80db1

Please sign in to comment.