Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change fedora template for range of dependencies #95

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

fedorkk
Copy link

@fedorkk fedorkk commented Sep 1, 2017

It's a decision for #94

@fedorkk
Copy link
Author

fedorkk commented Sep 1, 2017

There is a problem with String prepend method. Travis environment configured with ruby 1.8.7. Is it necessary to use so old ruby version? It's expired since 2014.

@voxik
Copy link
Member

voxik commented Sep 1, 2017

Thx for the PR. I'll take look later ...

Is it necessary to use so old ruby version?

Well, yes ... gem2rpm is still available in EPEL6.

Fix for ruby 1.8.7
@fedorkk
Copy link
Author

fedorkk commented Sep 1, 2017

Ok, I fixed it for 1.8.7. Thre is one more problem with undefined minitest, but I don't know how I could break it.

@pvalena
Copy link
Contributor

pvalena commented Aug 18, 2020

@voxik what's the status of this?

@voxik
Copy link
Member

voxik commented Aug 19, 2020

What I really don't like is the change in the template. As I already mentioned in #94, the BRs should not be versioned. The dependencies does not matters, the only thing which matters is if the test suite is passing. Even if we figure out that the test suite is not passing, because BR was updated in Fedora, then again, restricting the BR does not fix the issue itself. And the opposite way, that the package becomes FTBFS just because the BR version is very restricted is also not tempting (although we could ask upstream to relax the dependency if we discovered the library is compatible with newer version).

IOW I'm fine accepting the PR without changing the default template, because the with is useful in itself, but I don't want to change the template.

@fedorkk
Copy link
Author

fedorkk commented Aug 19, 2020

I've been asked to make this PR in the Russian fedora community, but it was three years ago and I don't remember, what happens here. I can change the PR, but could you please describe more detailed, what would you prefer to have?

And is it really make sense to create rpm packages from gems? Almost all ruby developers use version control systems like rbenv and manage gems with bundler. It allows us to have different ruby versions with different gems for each project on one machine.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants