-
Notifications
You must be signed in to change notification settings - Fork 45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Guess the right template from /etc/os-release #108
base: master
Are you sure you want to change the base?
Conversation
1595078
to
4530ef8
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This reads well to me, but I'd feel better if #112 was merged and this rebased so CI could agree.
#112 was merged. Would you mind rebasing? |
Not objecting the intent of this PR, but I'd be a bit happier, if the functionality lived somewhere outside of the executable. This way, it would be better testable. Of course if there was test case attached, it would be even better. |
Hmm, looking on the PR in more detail, I am confused what is the purpose. We are already querying Lines 72 to 75 in 91b38c8
and Lines 27 to 36 in 91b38c8
So this would be step backward. |
4530ef8
to
e6acc87
Compare
(cherry picked from commit 91bc63e) Co-authored-by: Ewoud Kohl van Wijngaarden <[email protected]> Co-authored-by: Dan Čermák <[email protected]>
…ontains ID="opensuse-tumbleweed" (cherry picked from commit 7fa4f56)
At the moment you have to manually specify the template file name on Leap, as gem2rpm tries to use the opensuse-leap template on Leap, which does not exist. Therefore we fallback to the opensuse template instead. (cherry picked from commit 2f34876)
e6acc87
to
e23d592
Compare
This PR adds a few patches from openSUSE's fork to support guessing the correct template from
/etc/os-release