Add some description tests and remove superfluos description setup.

fedora-ruby · Apr 23, 2015 · 95f44d0 · 95f44d0
1 parent 23b0b23
commit 95f44d0
Show file tree

Hide file tree

Showing 2 changed files with 19 additions and 1 deletion.
diff --git a/lib/gem2rpm.rb b/lib/gem2rpm.rb
@@ -47,7 +47,6 @@ def Gem2Rpm.convert(fname, template=RUBYGEM_TEMPLATE, out=$stdout,
     # Deprecate, kept just for backward compatibility.
     format = Gem2Rpm::Format.new(package)
     spec = Gem2Rpm::Specification.new(package.spec)
-    spec.description ||= spec.summary
     config = Gem2Rpm::Configuration.instance.to_default
     download_path = ""
     unless local

diff --git a/test/test_specification.rb b/test/test_specification.rb
@@ -23,4 +23,23 @@ def test_dependencies
     assert_equal(['> 1.0'], @spec.dependencies.first.requirement)
   end
 
+  def test_description_empty
+    assert_equal "\n", @spec.description
+  end
+
+  def test_description_add_dot_when_missing
+    @gemspec.description = "description"
+    assert_equal "description.\n", @spec.description
+
+    @gemspec.description = "description."
+    assert_equal "description.\n", @spec.description
+  end
+
+  def test_description_use_summary_when_empty
+    assert_empty @spec.description.strip
+
+    @gemspec.summary = "summary"
+    assert_equal "summary.\n", @spec.description
+  end
+
 end