Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add RSS field in edit user page #1216

Merged
merged 2 commits into from
Sep 15, 2023
Merged

Add RSS field in edit user page #1216

merged 2 commits into from
Sep 15, 2023

Conversation

phsmoura
Copy link
Contributor

This is a working in progress for issue 1155

When I try to submit the form get the following error:
Unknown option: fasrssurl

Any tips how to fix this?

@abompard
Copy link
Member

Yes, you need to add the attribute to our objectClass in https://github.com/fedora-infra/freeipa-fas. Feel free to ask if you need any help.

@phsmoura
Copy link
Contributor Author

Also opened a PR in freeipa here: fedora-infra/freeipa-fas#143

Copy link
Member

@abompard abompard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! And I tested it, it works fine :-)
Two minor remarks:

  • could you please add "Fixes: #1155" to your commit message
  • please add a news fragment as described in the contributor doc

@phsmoura
Copy link
Contributor Author

phsmoura commented Sep 6, 2023

Done! Thanks for reviewing it :)

Copy link
Member

@abompard abompard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same here, the news fragment should contain the line that will be added to the changelog. Something like "Add the RSS URL to the user profile", for example.

@mergify mergify bot merged commit 9a2e75c into fedora-infra:dev Sep 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants