-
Notifications
You must be signed in to change notification settings - Fork 60
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add RSS field in edit user page #1216
Conversation
Yes, you need to add the attribute to our objectClass in https://github.com/fedora-infra/freeipa-fas. Feel free to ask if you need any help. |
Also opened a PR in freeipa here: fedora-infra/freeipa-fas#143 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! And I tested it, it works fine :-)
Two minor remarks:
- could you please add "
Fixes: #1155
" to your commit message - please add a news fragment as described in the contributor doc
Done! Thanks for reviewing it :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same here, the news fragment should contain the line that will be added to the changelog. Something like "Add the RSS URL to the user profile", for example.
Signed-off-by: Pedro Moura <[email protected]>
Signed-off-by: Pedro Moura <[email protected]>
This is a working in progress for issue 1155
When I try to submit the form get the following error:
Unknown option: fasrssurl
Any tips how to fix this?