Change ID field in apass_dr9 catalog #476
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
🤬 no idea why profile code broke. Tracking that down.... |
Version 2.0 introduced some kind of change that broke a couple of our tests. See feder-observatory#477 for more information.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #476 +/- ##
=======================================
Coverage 80.32% 80.32%
=======================================
Files 32 32
Lines 4067 4067
=======================================
Hits 3267 3267
Misses 800 800 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Looks like Vizier dropped the Vizier-generated ID for APASS entries. This uses the field number in stead, which is not unique to each star, but we generate our own unique ID anyway.
Going to YOLO this since it is blocking progress for some students working on AAVSO posters....