ItemStack refactor #12
Conversation
|
I think it's a good idea to provide "native" support for an ItemBuilder utility. |
|
That's a good idea. I'll try to implement one once the |
|
@Defman I will add the stack limitations now. |
…te required trait impl and derives.
crates/items/src/item_stack.rs
Outdated
| pub fn take(&mut self, amount: u32) -> Result<ItemStack, ItemStackError> { | ||
| if self.count <= amount { | ||
| return Err(if self.count == amount { | ||
| ItemStackError::EmptyStack |
There was a problem hiding this comment.
We do need to provide a good solution for taking the whole stack—this is useful for inventory handling in Feather, for example. I know there are talks of refactoring ItemStack to properly account for empty stacks, so we should revisit this point.
…, make fields private, clarify docs.
|
Hi @PauMAVA! We decided on Discord to merge If this PR is nearly ready, we can merge it now and finish the remaining work in a separate PR. Alternatively, we can move the PR to Feather. |
|
Hey! There are still lots of things to implement (mainly Item Stack Metadata). I think we could merge this and open a new PR on the feather repo and continue the implementation there. What do you think about it? I can open a new Draft PR there if you want. |
Sounds good to me. I'll merge the PR as is, and we can finish up the work in the Feather repo. |
|
Let me know when the repo has been moved to |
This draft PR is related to #6. We can discuss the implementation of the new ItemStack type here.