chore: Upgrade msw to 2.7.0 (and Node.js to 22.13.1) in /ui #4995
+234
−383
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The main purpose was to upgrade msw from 0.36.8 to 2.7.0, to get rid of
the security alerts of the old version. The upgrade turned out to be
quite difficult, and in the end I only got the tests to pass with this
combination of other dependencies:
- test running environment: @happy-dom/jest-environment
- jsdom (the default) or jest-fixed-jsdom (suggested in many places
around the internet) neither worked due to various different
errors.
- Node.js version: 22
- I don't have an explanation, but with Node 20 the tests often fail
to navigate to other pages, without visible errors, though
sometimes the tests do pass. I saw the same failing behavior in
other running environments than @happy-dom/jest-environment
too, but in those there were also some visible errors. With Node
22, the tests seem to run notably faster, which might be related.
- Version 22 has been in long-term support for quite a while now, so
it's good to move to it anyway.
Signed-off-by: Harri Lehtola <[email protected]>
I have only used the sample projects in the repository, and actually the Empty Registry there fails to load. But as far as I remember, it has always been like that for me, and I assumed it was expected since the project is indeed totally empty. 😄 
|
|
@franciscojavierarceo @peruukki that issue has been resolved for dev builds and will be fully resolved with the next release. |
redhatHameed
approved these changes
Feb 1, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
The main purpose was to upgrade msw from 0.36.8 to 2.7.0, to get rid of the security alerts of the old version. The upgrade turned out to be quite difficult, and in the end I also had to upgrade Node.js from 20 to 22, see more below.
Which issue(s) this PR fixes:
No specific issue for this, but the idea for the upgrade originated from #4451.
Misc
I only got the tests to pass with this combination of other dependencies: