fix record default value cannot be a collection/map of records #605
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ayoub-benali
previously approved these changes
Aug 12, 2024
There was a problem hiding this comment.
LGTM ! thanks for taking care of this
Edit: @ex-ratt the build is failing
ex-ratt
force-pushed
the
fix-collection-default-values
branch
from
69cd9de
to
add794e
Compare
|
I changed the line that had the issue, hopefully it'll work now. I enabled Github actions in my fork, but it does not work, because my fork does not have any tags (line 294 in build.sbt will fail if this is the case). But here it may work, fingers crossed. If not, then I will try again. PS: I force-pushed in order to prevent a confusing history of small fixes. Is this ok? |
|
Thanks for the fix 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #592
(Is there anything else I need to add? Seems like a small enough change that it doesn't need additional explanation, or does it?)