Support setting shared data via XDG_DATA_DIRS and XDG_DATA_HOME #124
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@wengxt Unlike #123, this PR uses |
|
Can you explain your use case? is there any reason you can't use user directory? |
wrvsrx
force-pushed
the
support-set-data-dir-via-xdg
branch
3 times, most recently
from
228385a
to
4307b14
Compare
In this PR, fcitx5-rime detect shared data using following logic: First fcitx5-rime find a directory contain `rime-data/default.yaml` via `fcitx::fs::StandardPath::locate`. Then it use `RIME_DATA_DIR` as fallback.
wrvsrx
force-pushed
the
support-set-data-dir-via-xdg
branch
from
4307b14
to
80955b3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR, fcitx5-rime detect shared data using following logic:
If fcitx5-rime can find
rime-data/default.yamlin$XDG_DATA_HOMEor$XDG_DATA_DIRS(usingfcitx::fs::StandardPath::scanDirectories), it will use it . Otherwise, it useRIME_DATA_DIRspecified during build time as fallback.