Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce log file feature #67

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

Sakthivel-Ramasamy
Copy link
Contributor

Made code changes to capture and save all logs (from start to finish) generated from webex_bot library to a file with more data in the logs. Log enhancement is made to coloredLogs as well.

Made code changes to capture and save all logs (from start to finish) generated from webex_bot library to a file with more data in the logs. Log enhancement is made to coloredLogs as well.
@Sakthivel-Ramasamy
Copy link
Contributor Author

Sakthivel-Ramasamy commented Dec 20, 2024

My tool was not able to pick up the webex_bot's log messages. I mapped my tool to use "webex_bot" logger created by webex_bot.py, but it missed out webex_websocket_client module's logs (from webex_websocket_client.py), as it was logging to its own logger created via logging.getLogger(__name__).

Also, even when I mapped my tool to use webex_bot's logger, it still missed out the initial log messages of webex_bot.py module.

With the code changes in this PR, all modules of webex_bot module will log to "webex_bot" logger and we can save the logs to a file, from the scratch.

Also, I have added code changes to trigger logger flush and close (via logging.shutdown()) when stop() is called.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant