Skip to content

Commit

Permalink
typo corrections
Browse files Browse the repository at this point in the history
  • Loading branch information
admin committed Feb 23, 2023
1 parent cb96307 commit 9a8ec5e
Show file tree
Hide file tree
Showing 22 changed files with 83 additions and 83 deletions.
2 changes: 1 addition & 1 deletion 8ed42c23dbad0510bcced03cd39619ce/checksum.txt
Original file line number Diff line number Diff line change
@@ -1 +1 @@
f55tVPRGeB2dpCevd5WkQ5T-JS826K3Z1uXVzJfgeGGKEbfNzC9g9jpiHU8L7C4SXQVgEogjS8LGKgqkqc_Coc255ysgX9rmdb0M6Kyif9GEukf9-YuYARv8uD7tLHtbJZKfP7iIRZ5tIMDIWSGAt683V9QW7eawCwASBScxlpImKbkWQ8YnF391boxCmZLipoOoIPMx9eG1l8gO8b0iIWS4t_FGDdKU33YKOduxhyoWyxQk2QQdM0J9-CEpaxcfS2QxUjMfxGtSbN-db7Kh0jwQs1gAupjsoYgW-B0hh5QN8zuIISPvyd3LSCJezWk_mPhTOYCo7hJBUuQVVZiDYVYuFLhfk3huMhlzt7ko9zTCejce18KmJOLSIV6O68H0HSy4aBSXJ500Cbb4eyo1NSjeKDDc-NaIhIPYrkPwGBFawhbDsKV-58xo6hZXr0uiQdyrhxXC5AKY3RIGdwIZmObHpL1W7jGlvsfs9xytsCicFV7ERnYekJiW2DVRd12TRB8yTbLDmNyKFwhggfDigudQXFqvNaQGRPRv3i-_SD0W2ozq16_WE0sgoIl6jlNsBXyEUQ8Yl0WaNVfn6j0fuc-OTV22_Izh8aX0Dh8l8zzFQfjSqgikqZWGMm2PmLlqCcYtHqdzjKZBXFzgMghyGv0iDyEGf8lZ4TDORgVkorQ
rKNVe3JERQN4HYV4VerzUxkYRGrlQ0PSiQKTogrOU5zL6tXy4F9Aq55eWaOTy3RBB5VcPgDi94weBbey2U0OjqRkdsC5SKQ1NOA2Q1TG2xfjbNwbqTN99WTVCFNo1NC73qx4cr_VEwpE9cy6Q97_qsn9lQe5SRrdbu7OOsSoiZVaVdyFVlpQZmDUg98BZ6QTA91ar8l9H5ycAowt2djjAzzzJpRZsvT0IT3kW9l40hPhqiukqg1007eJLhVeTQlE-rVmQqCPw1jTqHslqIMYLWHl62xetUxJWX7UX6aagKEuqbIrgsbZzNcHHT8a9vRdWJvNOkirerw4J1N_v6PVYXasdX5MT1Q0_0svKH3OvtOfF2X0Mt_ZE-Y5MMKV8xq5kLEcCxzdbinFs3LlJiYeeb1oQLAl5795FdUfrcN5HMQRxcB1V6aOrhvKRPitIiZbezFk-oeBdA8m8QZQUAmhvyg-ZtbbcJVMFVEhljLa6qTfogtzvPsrv7jxMJWdGCwQQOHYyWBZxiOK3inZKMPsFJgZxsQ7-CPTPN0dM1kGubEai0F3U-DwDddtths24fFcaTsaQlCbno6rJbGrrbrxD4E_AqbfTIn7P6KsH4oLk1Nds3NxDNtOYHFLsbAjr1PGTsFFE084x_x-9pjB3eEvL1xVm7s53WOsECtVZ1ck8Rs
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
<active>true</active>
<category>code_sanity</category>
<column_type>script</column_type>
<description>The use of the spread operator is controversal. On the one hand it provides a syntax short hand. However it renders code to be less readable and less testable. The use of the spread operator in most cases does not provide any advantages over alternatives and hence should be avoided.</description>
<description>The use of the spread operator is controversial. On the one hand it provides a syntax shorthand. However, it renders code to be less readable and less testable. The use of the spread operator in most cases does not provide any advantages over alternatives and hence should be avoided.</description>
<documentation_url/>
<finding_type>scan_finding</finding_type>
<name>CodeSanity - Avoid the spread operator</name>
Expand Down Expand Up @@ -38,13 +38,13 @@
<sys_created_by>admin</sys_created_by>
<sys_created_on>2022-11-02 10:31:01</sys_created_on>
<sys_id>2ed0c523db7e91106a03dad1f39619e1</sys_id>
<sys_mod_count>7</sys_mod_count>
<sys_mod_count>9</sys_mod_count>
<sys_name>CodeSanity - Avoid the spread operator</sys_name>
<sys_package display_value="CodeSanity WORK IN PROGRESS" source="x_snc_codesanity">8ed42c23dbad0510bcced03cd39619ce</sys_package>
<sys_policy/>
<sys_scope display_value="CodeSanity WORK IN PROGRESS">8ed42c23dbad0510bcced03cd39619ce</sys_scope>
<sys_update_name>scan_column_type_check_2ed0c523db7e91106a03dad1f39619e1</sys_update_name>
<sys_updated_by>admin</sys_updated_by>
<sys_updated_on>2022-12-05 19:31:57</sys_updated_on>
<sys_updated_on>2023-02-23 17:15:10</sys_updated_on>
</scan_column_type_check>
</record_update>
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
<active>true</active>
<category>code_sanity</category>
<column_type>script</column_type>
<description>The use of arrow functions is controversal. On the one hand it provides a syntax short hand for callback functions. However it renders code to be less readable and less testable. The use of arrow functions does not provide advantages over alternatives and hence should be avoided.</description>
<description>The use of arrow functions is controversial. On the one hand it provides a syntax shorthand for callback functions. However, it renders code to be less readable and less testable. The use of arrow functions does not provide advantages over alternatives and hence should be avoided.</description>
<documentation_url/>
<finding_type>scan_finding</finding_type>
<name>CodeSanity - Avoid arrow functions</name>
Expand Down Expand Up @@ -33,13 +33,13 @@
<sys_created_by>admin</sys_created_by>
<sys_created_on>2022-11-02 10:13:23</sys_created_on>
<sys_id>cb9b346fdb3e91106a03dad1f3961993</sys_id>
<sys_mod_count>3</sys_mod_count>
<sys_mod_count>5</sys_mod_count>
<sys_name>CodeSanity - Avoid arrow functions</sys_name>
<sys_package display_value="CodeSanity WORK IN PROGRESS" source="x_snc_codesanity">8ed42c23dbad0510bcced03cd39619ce</sys_package>
<sys_policy/>
<sys_scope display_value="CodeSanity WORK IN PROGRESS">8ed42c23dbad0510bcced03cd39619ce</sys_scope>
<sys_update_name>scan_column_type_check_cb9b346fdb3e91106a03dad1f3961993</sys_update_name>
<sys_updated_by>admin</sys_updated_by>
<sys_updated_on>2022-11-02 10:30:40</sys_updated_on>
<sys_updated_on>2023-02-23 17:15:58</sys_updated_on>
</scan_column_type_check>
</record_update>
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
<scan_linter_check action="INSERT_OR_UPDATE">
<active>true</active>
<category>code_sanity</category>
<description>Debug output should always be temporary and should be removed as soon as the analysed issue has been resolved. </description>
<description>Debug output should always be temporary and should be removed as soon as the analyzed issue has been resolved. </description>
<documentation_url/>
<finding_type/>
<name>CodeSanity - Debug output</name>
Expand Down Expand Up @@ -67,13 +67,13 @@
<sys_created_by>admin</sys_created_by>
<sys_created_on>2022-04-27 12:57:14</sys_created_on>
<sys_id>090e08b2db0f0510b652edb3059619bc</sys_id>
<sys_mod_count>9</sys_mod_count>
<sys_mod_count>10</sys_mod_count>
<sys_name>CodeSanity - Debug output</sys_name>
<sys_package display_value="CodeSanity WORK IN PROGRESS" source="x_snc_codesanity">8ed42c23dbad0510bcced03cd39619ce</sys_package>
<sys_policy/>
<sys_scope display_value="CodeSanity WORK IN PROGRESS">8ed42c23dbad0510bcced03cd39619ce</sys_scope>
<sys_update_name>scan_linter_check_090e08b2db0f0510b652edb3059619bc</sys_update_name>
<sys_updated_by>admin</sys_updated_by>
<sys_updated_on>2022-08-02 12:27:45</sys_updated_on>
<sys_updated_on>2023-02-23 14:04:50</sys_updated_on>
</scan_linter_check>
</record_update>
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@
<finding_type>scan_finding</finding_type>
<name>CodeSanity - Deprecated logging</name>
<priority>1</priority>
<resolution_details>Refactor the code to use "gs.info()", "gs.warn()" and "gs.error()". Use "gs.debug()" only temporarily for debbugging purposes.</resolution_details>
<resolution_details>Refactor the code to use "gs.info()", "gs.warn()" and "gs.error()". Use "gs.debug()" only temporarily for debugging purposes.</resolution_details>
<run_condition/>
<score_max>100</score_max>
<score_min>0</score_min>
Expand Down Expand Up @@ -59,13 +59,13 @@
<sys_created_by>admin</sys_created_by>
<sys_created_on>2023-01-06 10:44:47</sys_created_on>
<sys_id>3ac2ff10db18e5906a03dad1f3961926</sys_id>
<sys_mod_count>5</sys_mod_count>
<sys_mod_count>6</sys_mod_count>
<sys_name>CodeSanity - Deprecated logging</sys_name>
<sys_package display_value="CodeSanity WORK IN PROGRESS" source="x_snc_codesanity">8ed42c23dbad0510bcced03cd39619ce</sys_package>
<sys_policy/>
<sys_scope display_value="CodeSanity WORK IN PROGRESS">8ed42c23dbad0510bcced03cd39619ce</sys_scope>
<sys_update_name>scan_linter_check_3ac2ff10db18e5906a03dad1f3961926</sys_update_name>
<sys_updated_by>admin</sys_updated_by>
<sys_updated_on>2023-02-21 16:53:17</sys_updated_on>
<sys_updated_on>2023-02-23 14:10:51</sys_updated_on>
</scan_linter_check>
</record_update>
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
<scan_linter_check action="INSERT_OR_UPDATE">
<active>true</active>
<category>code_sanity</category>
<description>Using exceptions is a highly questionable and disputed coding practise. Although it may appear elegant zu fork out of the execution flow at any time and implement error handling somewhere else, experience shows that many exceptions are either not catched or not processed properly. In most cases, just returning from a function and returning an error state is the more robust option. Unless there is a very strict architectural concept about when exceptions should be thrown and how the errors should be handled, using that technique results in less readable code and less robust applications. Some even argue that throwing exceptions is like dumping your garbage into the backyard of your neighbor - as usually its not the developer who throws the exception will be the one who handles it. Hence throwing exceptions must be avoided.</description>
<description>Using exceptions is a highly questionable and disputed coding practice. Although it may appear elegant zu fork out of the execution flow at any time and implement error handling somewhere else, experience shows that many exceptions are either not being catched or not processed properly. In most cases, just returning from a function and returning an error state is the more robust option. Unless there is a very strict architectural concept about when exceptions should be thrown and how the errors should be handled, using that technique results in less readable code and less robust applications. Some even argue that throwing exceptions is like dumping your garbage into the backyard of your neighbor - as usually its not the developer who throws the exception will be the one who handles it. Hence throwing exceptions must be avoided.</description>
<documentation_url/>
<finding_type/>
<name>CodeSanity - Throwing exceptions</name>
Expand Down Expand Up @@ -31,13 +31,13 @@
<sys_created_by>admin</sys_created_by>
<sys_created_on>2022-03-15 16:58:22</sys_created_on>
<sys_id>6bd82ff8db12cd10b652edb305961910</sys_id>
<sys_mod_count>14</sys_mod_count>
<sys_mod_count>15</sys_mod_count>
<sys_name>CodeSanity - Throwing exceptions</sys_name>
<sys_package display_value="CodeSanity WORK IN PROGRESS" source="x_snc_codesanity">8ed42c23dbad0510bcced03cd39619ce</sys_package>
<sys_policy/>
<sys_scope display_value="CodeSanity WORK IN PROGRESS">8ed42c23dbad0510bcced03cd39619ce</sys_scope>
<sys_update_name>scan_linter_check_6bd82ff8db12cd10b652edb305961910</sys_update_name>
<sys_updated_by>admin</sys_updated_by>
<sys_updated_on>2022-08-05 14:03:34</sys_updated_on>
<sys_updated_on>2023-02-23 14:05:31</sys_updated_on>
</scan_linter_check>
</record_update>
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
<active>true</active>
<category>code_sanity</category>
<description>The use of the constructor of the Javascript Date class is problematic. The default behavior is the initialization with the current date and time.&#13;
Somesequent useage of functions like setMonth() or setUTCMonth() may not produce expected results if the set date is at the end of a month.</description>
Sometimes the use of functions like setMonth() or setUTCMonth() may not produce expected results if the set date is at the end of a month.</description>
<documentation_url/>
<finding_type/>
<name>CodeSanity - Date() without parameter</name>
Expand Down Expand Up @@ -34,13 +34,13 @@ E.g. to initialize a Date object with the current date and time use "new Date(Da
<sys_created_by>admin</sys_created_by>
<sys_created_on>2022-04-01 07:08:55</sys_created_on>
<sys_id>9e940196db2a0150bcced03cd396197f</sys_id>
<sys_mod_count>8</sys_mod_count>
<sys_mod_count>9</sys_mod_count>
<sys_name>CodeSanity - Date() without parameter</sys_name>
<sys_package display_value="CodeSanity WORK IN PROGRESS" source="x_snc_codesanity">8ed42c23dbad0510bcced03cd39619ce</sys_package>
<sys_policy/>
<sys_scope display_value="CodeSanity WORK IN PROGRESS">8ed42c23dbad0510bcced03cd39619ce</sys_scope>
<sys_update_name>scan_linter_check_9e940196db2a0150bcced03cd396197f</sys_update_name>
<sys_updated_by>admin</sys_updated_by>
<sys_updated_on>2022-11-18 10:58:54</sys_updated_on>
<sys_updated_on>2023-02-23 14:07:43</sys_updated_on>
</scan_linter_check>
</record_update>
Original file line number Diff line number Diff line change
Expand Up @@ -3,15 +3,15 @@
<active>true</active>
<category>code_sanity</category>
<description>Flow Designer Flows and Subflows are designed to allow low-code/no-code citizen developers to assemble low complexity, ad-hoc logic for their apps.&#13;
Flow Designer is NOT suitable to built high-complex pro-code applications.&#13;
It is perfectly fine to use scripted action steps in a flow or subflow to let low-code/no-code developers access features that are implemented in script includes. However if there is the perceived need to run a flow or subflow from within another script, this is a strong indicator of a substantial architectural design flaw. Why should a pro-coder call a low-code/no-code API? If that is the case, important aspects of an application's business logic has been implemented in flows or subflows instead of script includes - or worse it is randomly distributed between script includes and flows.</description>
Flow Designer is NOT suitable to built high-complex applications.&#13;
It is perfectly fine to use scripted action steps in a Flow or Subflow to let low-code/no-code developers access features that are implemented in script includes. However if there is the perceived need to run a Flow or Subflow from within another script, this is a strong indicator of a substantial architectural design flaw. Why should a pro-coder call a low-code/no-code API? If that is the case, important aspects of an application's business logic has been implemented in Flows or Subflows instead of Script Includes - or worse it is randomly distributed between Script Includes and Flows.</description>
<documentation_url/>
<finding_type>scan_finding</finding_type>
<name>CodeSanity - Do not run flows from scripts</name>
<name>CodeSanity - Do not run Flows from scripts</name>
<priority>1</priority>
<resolution_details>Refactor the flows to make use of functions implemented in script includes - not vice versa.&#13;
Turn the complex flows, subflows and actions that actually contain substantial parts of the business logic into script includes.&#13;
Expose features using flows and subflows to low-code/no-code developers where needed. </resolution_details>
<resolution_details>Refactor the Flows to make use of functions implemented in Script Includes - not vice versa.&#13;
Turn the complex Flows, Subflows and Flow Actions that actually contain substantial parts of the business logic into Script Includes.&#13;
Expose features using Flows and Subflows to low-code/no-code developers where needed. </resolution_details>
<run_condition/>
<score_max>100</score_max>
<score_min>0</score_min>
Expand All @@ -34,18 +34,18 @@ Expose features using flows and subflows to low-code/no-code developers where ne
}
})(engine);]]></script>
<short_description>Scripts must not run flows.</short_description>
<short_description>Scripts must not run Flows.</short_description>
<sys_class_name>scan_linter_check</sys_class_name>
<sys_created_by>admin</sys_created_by>
<sys_created_on>2022-08-15 15:49:46</sys_created_on>
<sys_id>ed3393c6dbd951109232dad1f39619cf</sys_id>
<sys_mod_count>4</sys_mod_count>
<sys_name>CodeSanity - Do not run flows from scripts</sys_name>
<sys_mod_count>5</sys_mod_count>
<sys_name>CodeSanity - Do not run Flows from scripts</sys_name>
<sys_package display_value="CodeSanity WORK IN PROGRESS" source="x_snc_codesanity">8ed42c23dbad0510bcced03cd39619ce</sys_package>
<sys_policy/>
<sys_scope display_value="CodeSanity WORK IN PROGRESS">8ed42c23dbad0510bcced03cd39619ce</sys_scope>
<sys_update_name>scan_linter_check_ed3393c6dbd951109232dad1f39619cf</sys_update_name>
<sys_updated_by>admin</sys_updated_by>
<sys_updated_on>2023-02-19 19:23:24</sys_updated_on>
<sys_updated_on>2023-02-23 14:10:01</sys_updated_on>
</scan_linter_check>
</record_update>
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
<conditions table="sys_app">scope!=global^EQ<item endquery="false" field="scope" goto="false" newquery="false" operator="!=" or="false" value="global"/>
<item endquery="true" field="" goto="false" newquery="false" operator="=" or="false" value=""/>
</conditions>
<description>Documentation is often missing or not up-to-date. One reason is that documentation assets are often not part of the software itself, maintained by different people or teams. Where an applications contains its own documentation, it is more likely that the documentation itself is kept in a good shape. </description>
<description>Documentation is often missing or not up to date. One reason is that documentation assets are often not part of the software itself, maintained by different people or teams. Where an application contains its own documentation, it is more likely that the documentation itself is kept in a good shape. </description>
<documentation_url/>
<finding_type>scan_finding</finding_type>
<name>CodeSanity - App must have a manual page</name>
Expand Down Expand Up @@ -36,14 +36,14 @@
<sys_created_by>admin</sys_created_by>
<sys_created_on>2023-01-17 15:47:52</sys_created_on>
<sys_id>27712dc8db6ce1106a03dad1f3961908</sys_id>
<sys_mod_count>1</sys_mod_count>
<sys_mod_count>2</sys_mod_count>
<sys_name>CodeSanity - App must have a manual page</sys_name>
<sys_package display_value="CodeSanity WORK IN PROGRESS" source="x_snc_codesanity">8ed42c23dbad0510bcced03cd39619ce</sys_package>
<sys_policy/>
<sys_scope display_value="CodeSanity WORK IN PROGRESS">8ed42c23dbad0510bcced03cd39619ce</sys_scope>
<sys_update_name>scan_table_check_27712dc8db6ce1106a03dad1f3961908</sys_update_name>
<sys_updated_by>admin</sys_updated_by>
<sys_updated_on>2023-02-02 15:38:24</sys_updated_on>
<sys_updated_on>2023-02-23 14:13:30</sys_updated_on>
<table>sys_app</table>
<use_manifest>false</use_manifest>
</scan_table_check>
Expand Down
Loading

0 comments on commit 9a8ec5e

Please sign in to comment.