Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Command Line Options to use arg_name, not arg_type #1032

Merged
merged 3 commits into from
Nov 22, 2024

Conversation

KhyatiMahendru
Copy link
Collaborator

No description provided.

@KhyatiMahendru KhyatiMahendru changed the title Update Registrar Command Line Options to use arg_name, not arg_type Update Command Line Options to use arg_name, not arg_type Nov 22, 2024
Copy link
Collaborator

@grafnu grafnu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One small change to make, and then it all looks good to go!

When submitting, the practice we follow is to remove all of the PR comments, so there's no commit history included (which is the default GitHub behavior), and rather just rely on the PR# link of the title. If you take a look at the git log you'll see what I mean!

@KhyatiMahendru
Copy link
Collaborator Author

When submitting, the practice we follow is to remove all of the PR comments, so there's no commit history included (which is the default GitHub behavior), and rather just rely on the PR# link of the title. If you take a look at the git log you'll see what I mean!

By this, do you mean I should "squash and merge"?

@grafnu
Copy link
Collaborator

grafnu commented Nov 22, 2024

When submitting, the practice we follow is to remove all of the PR comments, so there's no commit history included (which is the default GitHub behavior), and rather just rely on the PR# link of the title. If you take a look at the git log you'll see what I mean!

By this, do you mean I should "squash and merge"?

Yes -- once you start "Squash and Merge" there's a box that'll have the commit history in it -- delete that so there's nothing in the box -- then the Title of the PR is the record of what it was. Sometimes if it's really important then we can put something in the box, but not just "because"!

@KhyatiMahendru KhyatiMahendru merged commit 9e9ccf8 into faucetsdn:master Nov 22, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants