discovery node improvements - bacnet points, cli, integration test

[noursaidi]

No description provided.

[grafnu]

number generator for what?

[noursaidi]

For testing. At the moment, I'm forced to have some "vendor" discovery because that's what sequencer uses, and it makes testing a whole lot easier, e.g. run "vendor" discovery for ten seconds, should receive ten events [1,2,3,4,5,6,7,8,9,10], etc.

[grafnu]

But where does the sequential number go? Is it just the event_no -- b/c that's always sequential. Do you just mean it's a periodic number generator? (As in, 1-every-10-seconds?)

…

On Tue, Nov 19, 2024 at 5:57 AM Noureddine ***@***.***> wrote: ***@***.**** commented on this pull request. ------------------------------ In misc/discoverynode/README.md <#1029 (comment)>: > @@ -2,11 +2,41 @@ ## Notes -`vendor` discovery family is a counter which increments every second +`vendor` discovery family is actually sequential number generator at one second increments. For testing. At the moment, I'm forced to have some "vendor" discovery because that's what sequencer uses, and it makes testing a whole lot easier, e.g. run "vendor" discovery for ten seconds, should receive ten events [1,2,3,4,5,6,7,8,9,10], etc. — Reply to this email directly, view it on GitHub <#1029 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAIEPDZC2DFWDUHL4FRQ4AT2BM7VPAVCNFSM6AAAAABSCB54UGVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDINBVGU2TMNJRHA> . You are receiving this because your review was requested.Message ID: ***@***.***>

[noursaidi]

The sequential number goes into the scan_addr field.

So, to pass sequencer tests (which typically have a scan_duration of 10 seconds) I need ten devices in the site model with vendor addrs 1,2,...,11 respectively. It might also be occasionally flakey, but does the job.

Really its a test family I've called vendor for convenience

[grafnu]

"into the scan_addr field." ==> "discovery family is actually sequential number generator placed into the scan_addr field at one second increments"

…

On Tue, Nov 19, 2024 at 6:37 AM Noureddine ***@***.***> wrote: The sequential number goes into the scan_addr field. So, to pass sequencer tests (which typically have a scan_duration of 10 seconds) I need ten devices in the site model with vendor addrs 1,2,...,11 respectively. It might also be occasionally flakey, but does the job. Really its a test family I've called vendor for convenience — Reply to this email directly, view it on GitHub <#1029 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAIEPDYQ53HVIDOBHXA5SOT2BNEJTAVCNFSM6AAAAABSCB54UGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDIOBVHA4TGNRYG4> . You are receiving this because your review was requested.Message ID: ***@***.***>