Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Expose option to set precision for variables #103

Open
wants to merge 74 commits into
base: dev
Choose a base branch
from
Open

Expose option to set precision for variables #103

wants to merge 74 commits into from

Conversation

schmoelder
Copy link
Contributor

@schmoelder schmoelder commented Mar 2, 2024 •
edited
Loading

This PR allows two things:

  • Exposing a precision attribute of the OptimizationVariable which can be used to round its value (which can be useful when dealing with floating point issues of even for termination criteria.
  • Passing this precision to the transform functions when determining bounds of the variables. This could maybe help with the issues we're experiencing with COBYLA.

To do

  • Check if this helps with COBYLA
  • Clean up code (e.g. what does validate_x do?)
  • Finish tests

schmoelder and others added 30 commits January 24, 2024 09:52
@schmoelder
Improve ReferenceIO solution shape check
7c32af2
@schmoelder
Check cstr volume only when flow rate is not None
cbd69ae
@schmoelder
Fix calculation of conversion rates for MSSMA model
5e10679
@schmoelder
Update CI
b4bb2a1 
- Fix caching
- Update Python versions
- Test on MacOS
@schmoelder
Only evaluate objects registered in objective/constraint functions
00d72cc
@schmoelder
Fix objective names
c5f71d3
@schmoelder
Restructure OptimizationProblem metrics
438c542
@schmoelder
Add results in example callback.
5b4dd04
@flo-schu @schmoelder
move create_hopsy_problem to separate method
9015404
@flo-schu @schmoelder
implement else action if shapes of rounded and unrounded problems do …
f4b35b1 
…not match
@schmoelder
Add support for creating x0 with linear equality constraints
580a84e
@schmoelder
Raise warning if x0 is smaller than popsize
0125189
@schmoelder
Fix behavior of comparisons to references with multiple components
3e1898b
@schmoelder
Add examples for SMA parameter determination using Yamamoto and inver…
70e9dfb 
…se method
@schmoelder
Temporarily disable test_fit_column_parameters to avoid breaking CI
dd851e7
@schmoelder
Fix jupytext formatting
5287ec8
@schmoelder
Add n_difference_metrics property
89ec75e
@schmoelder
Improve figure styling
394d08c
@schmoelder
Allow setting empty list for output_state for units without destination
6e49da1
@schmoelder
Untransform x when evaluating callbacks.
a9389d7
@schmoelder
Clarify that OptimizationProblem.transform expects independent space
980dad7
@schmoelder
Remove increased burn-in when using equality constraints
23c04ce
@schmoelder
Assume x0 contains only independent variables
d451fbc
@schmoelder
Return dependent variables for x0 by default
aa3f922
@schmoelder
Move chebyshev center to own method
fd13a12
@schmoelder
Improve docstring
895dfe8
@schmoelder
Add check_individual method
b47cb30
@schmoelder
Move validation of x0 to OptimizerBase
8dfde9a
@schmoelder
Small fix: adjust variable types in optimizer.check_x0
8c07312
@schmoelder
Use original space for chebychev center
c5f20f8
@schmoelder schmoelder force-pushed the dev branch 4 times, most recently from b3c1d2f to bd5cccc Compare March 22, 2024 07:00
@schmoelder schmoelder force-pushed the expose-option-to-set-precision-for-variables branch from 8cacd9c to 8f624bb Compare March 22, 2024 07:05
@schmoelder schmoelder force-pushed the dev branch 4 times, most recently from d10f69b to cd4c8ee Compare March 26, 2024 15:33
@schmoelder schmoelder force-pushed the dev branch 11 times, most recently from 35e0c67 to d97cf31 Compare December 4, 2024 16:47
@schmoelder schmoelder added this to the v0.11.0 milestone Dec 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@flo-schu flo-schu flo-schu left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v0.11.0
Development

Successfully merging this pull request may close these issues.
4 participants
@schmoelder @flo-schu @jAniceto @ronald-jaepel