Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: migrate to node test runner #185

Merged
merged 3 commits into from
Jan 10, 2025
Merged

chore: migrate to node test runner #185

merged 3 commits into from
Jan 10, 2025

Conversation

ilteoood
Copy link
Contributor

@ilteoood ilteoood commented Jan 8, 2025

Checklist

dancastillo
dancastillo approved these changes Jan 10, 2025
View reviewed changes
Copy link
Member

@dancastillo dancastillo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Fdawgs
Fdawgs requested changes Jan 10, 2025
View reviewed changes
Copy link
Member

@Fdawgs Fdawgs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please readd tap to .gitignore. it's from the boilerplate from the skeleton repo, so it is consistent with all the other fastify repos. :)

@ilteoood ilteoood requested a review from Fdawgs January 10, 2025 18:22
@Fdawgs Fdawgs merged commit 2c9f030 into fastify:master Jan 10, 2025
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Fdawgs Fdawgs Fdawgs approved these changes

@dancastillo dancastillo dancastillo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ilteoood @dancastillo @Fdawgs