Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 Fix printing HTML from Rich output #1055

Merged
merged 1 commit into from
Nov 18, 2024
Merged

🐛 Fix printing HTML from Rich output #1055

merged 1 commit into from
Nov 18, 2024

Conversation

tiangolo
Copy link
Member

@tiangolo tiangolo commented Nov 18, 2024

🐛 Fix printing HTML from Rich output

It seems capturing was not working, I think it did at #847 because tests were passing, but it seems it's no longer working.

Using io.StringIO() seems to be the suggested way in an issue: Textualize/rich#247 (comment)

@tiangolo tiangolo marked this pull request as ready for review November 18, 2024 22:05
@tiangolo tiangolo merged commit 376b907 into master Nov 18, 2024
25 of 26 checks passed
@tiangolo tiangolo deleted the rich-html branch November 18, 2024 22:06
@bollwyvl
Copy link

It looks like not all of the whl/sdist releases of 0.13.1 went through:

@tiangolo
Copy link
Member Author

Thanks @bollwyvl! Yep, it seems there was a hiccup in the actions, I re-ran them and then it worked. 🤓

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants