Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop Python 3.8 & add official support for Python 3.13 & Django 5.1 #608

Merged
merged 4 commits into from
Nov 28, 2024

Conversation

samiashi
Copy link
Contributor

@samiashi samiashi commented Nov 25, 2024

@samiashi samiashi force-pushed the samielachi/add-more-django-python branch from 1481a3d to 972f3bd Compare November 27, 2024 05:50
@samiashi samiashi changed the title Add official support for Python 3.13 & Django 5.1 Drop Python 3.8 & add official support for Python 3.13 & Django 5.1 Nov 27, 2024
@katiam2
Copy link
Collaborator

katiam2 commented Nov 28, 2024

@samiashi could you please re-base your brunch against main to include the latest fixes that allow builds to trigger

@samiashi samiashi force-pushed the samielachi/add-more-django-python branch from 81d86f0 to 3cb263b Compare November 28, 2024 10:30
@samiashi
Copy link
Contributor Author

@katiam2 I've rebased now

Is the (3.12) failure expected?

coveralls-django4.2-python3.12: commands[4]> coveralls
  Error running coveralls: Not on TravisCI. You have to provide either repo_token in .coveralls.yml or set the COVERALLS_REPO_TOKEN env var.
  Traceback (most recent call last):
    File "/home/runner/work/django-jazzmin/django-jazzmin/.tox/coveralls-django4.2-python3.12/lib/python3.12/site-packages/coveralls/cli.py", line 65, in main
      coverallz = Coveralls(
                  ^^^^^^^^^^
    File "/home/runner/work/django-jazzmin/django-jazzmin/.tox/coveralls-django4.2-python3.12/lib/python3.12/site-packages/coveralls/api.py", line 47, in __init__
      self.ensure_token()
    File "/home/runner/work/django-jazzmin/django-jazzmin/.tox/coveralls-django4.2-python3.12/lib/python3.12/site-packages/coveralls/api.py", line 60, in ensure_token
      raise CoverallsException(
  coveralls.exception.CoverallsException: Not on TravisCI. You have to provide either repo_token in .coveralls.yml or set the COVERALLS_REPO_TOKEN env var.

@katiam2
Copy link
Collaborator

katiam2 commented Nov 28, 2024

@samiashi it seems that test coverage tool's token has expired. We can merge without it for now. I’ll do some visual checks and try to get this merged soon.

@farridav
Copy link
Owner

we will resolve coveralls issue in a follow up PR, thanks for the contribution !!

@farridav farridav merged commit 92a8f35 into farridav:main Nov 28, 2024
7 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants