Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid removing strings likes "en/" when it's not in language code #529

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Avoid removing strings likes "en/" when it's not in language code #529

wants to merge 2 commits into from

Conversation

jameslao
Copy link
Contributor

@jamesgilmorelyst jamesgilmorelyst linked an issue Mar 23, 2024 that may be closed by this pull request
i18n Language Chooser stripping admin paths/urls of language code wherever found #510
Open
@katiam2
Copy link
Collaborator

katiam2 commented Nov 28, 2024

@jameslao please add a test as this is a code change.

Note that the main branch was merged into yours to reflect build config changes.

@katiam2 katiam2 added the Awaiting changes Needs changes from the author label Nov 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Awaiting changes Needs changes from the author
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

i18n Language Chooser stripping admin paths/urls of language code wherever found
2 participants
@jameslao @katiam2