-
Notifications
You must be signed in to change notification settings - Fork 287
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Custom menu definition support #241
Conversation
@farridav Many thanks for remembering! Looks good, two questions:
|
Supporting N levels of nesting is definitely something that needs scoping out |
6a8f400
to
82e7cf7
Compare
Hi! I just discovered django-jazzmin and love it. This PR seems to be only feature that I am actually missing out on. Are there any plans to move forward with this ? |
I've got a building list of things to take care of here, and my other maintainer is currently unavailable, so it's been tricky getting it all done, along with my other work. This ticket is definitely one I want to get finished up, hopefully within the next few weeks if possible. |
I wonder if it is possible to add a apps group design in this feature as it is quite necessary for a project with a series of apps. |
It's not a push, but just a question. |
82e7cf7
to
b839a79
Compare
Hey just checking to see if this feature still has a path forward. Thanks for the hard work! |
Yes this is still definitely something I want to get to, I'll try to set
some time asides over the next couple of weeks to get it finished off, it's
been sitting here for ages ... :(
…On Mon, 6 Jun 2022, 19:54 chaleyct, ***@***.***> wrote:
Hey just checking to see if this feature still has a path forward. Thanks
for the hard work!
—
Reply to this email directly, view it on GitHub
<#241 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAWUF3KVPJIBOR7YFNFC3UTVNZCOJANCNFSM4VFZNZNA>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
) | ||
|
||
User = get_user_model() | ||
register = Library() | ||
logger = logging.getLogger(__name__) | ||
|
||
|
||
def _process_models(app_label: str, models: List[Dict], options: Dict) -> List[Dict]: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a simple extraction to satisfy ruff requirements. Tests were added to the original message first and then the refactoring followed.
Already implemented |
Closes: #195
Aims to allow an entirely custom menu using an app-> model list mapping
e.g
"custom_menu": {"auth": ["books.book"], "any_name": ["auth.user", "auth.group"]}
@djpretzel .. I have not forgotten about this, let me know if it supports your use case
TODO: