Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cumulative Update for Keras 2.2.0 and some fixes and Explanations in the README.md #103

Merged
merged 18 commits into from
Jul 1, 2018

Conversation

Pyrestone
Copy link
Contributor

This Pull request includes fixes for the issues addressed in #102 #101, #96, #94 and #76
along with the bug in farizrahman4u/seq2seq#177 and farizrahman4u/seq2seq#250
(both caused by calls to the deprecated keras.engine.topology class.)

@Pyrestone
Copy link
Contributor Author

While waiting for a response from @farizrahman4u, you can use the installation instructions from pyrestone/recurrentshop to install the library for keras 2.2.0

@Pyrestone
Copy link
Contributor Author

I added another fix for the Tensorflow teacher-forcing bug, fixing #81 and making the tf-teacher-force branch obsolete.

@farizrahman4u
Copy link
Owner

Thanks for the effort. Couple of small changes required.

README.md Outdated

# Run the RNN over a random sequence
# Don't forget the batch shape when calling the model!
out=model.predict(np.random.random((1, 7, 5)))
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Spaces around =

README.md Outdated
y = rnn2(x)
model2 = Model(x, y)

out2=model2.predict(np.random.random((1, 7, 5)))
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Spaces around =

@Pyrestone
Copy link
Contributor Author

@farizrahman4u Done.

@farizrahman4u farizrahman4u merged commit 43635f3 into farizrahman4u:master Jul 1, 2018
@farizrahman4u
Copy link
Owner

Lgtm, Thanks!

@Pyrestone Pyrestone deleted the fariz branch July 1, 2018 19:13
@ty5491003
Copy link

ty5491003 commented Jul 2, 2018

Thank you for your work!

I just tested it, worked! thanks again!

@Pyrestone Pyrestone restored the fariz branch July 2, 2018 17:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants