-
Notifications
You must be signed in to change notification settings - Fork 218
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cumulative Update for Keras 2.2.0 and some fixes and Explanations in the README.md #103
Conversation
Fixed the bug!
Updated engine.py
Merge sumanthrao/master
Update engine.py
While waiting for a response from @farizrahman4u, you can use the installation instructions from pyrestone/recurrentshop to install the library for keras 2.2.0 |
Fixed Teacher forcing in TF backend
I added another fix for the Tensorflow teacher-forcing bug, fixing #81 and making the tf-teacher-force branch obsolete. |
Thanks for the effort. Couple of small changes required. |
README.md
Outdated
|
||
# Run the RNN over a random sequence | ||
# Don't forget the batch shape when calling the model! | ||
out=model.predict(np.random.random((1, 7, 5))) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Spaces around =
README.md
Outdated
y = rnn2(x) | ||
model2 = Model(x, y) | ||
|
||
out2=model2.predict(np.random.random((1, 7, 5))) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Spaces around =
Spaces around = for prettyness
@farizrahman4u Done. |
Lgtm, Thanks! |
Thank you for your work! I just tested it, worked! thanks again! |
This Pull request includes fixes for the issues addressed in #102 #101, #96, #94 and #76
along with the bug in farizrahman4u/seq2seq#177 and farizrahman4u/seq2seq#250
(both caused by calls to the deprecated
keras.engine.topology
class.)