Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix grammatical errors and typo in code #2411

Merged
merged 2 commits into from
Dec 7, 2024
Merged

Conversation

Danyylka
Copy link
Contributor

@Danyylka Danyylka commented Nov 28, 2024

Fixed:

Changed "Commands must" to "Commands must be" for grammatical correctness.
Corrected "import { geSSLHubRpcClient" to "import { getSSLHubRpcClient" to fix the typo.
Why it's useful:
These changes fix grammatical errors and a typo, ensuring the code is syntactically correct and easier to read.


PR-Codex overview

This PR focuses on correcting a typo in the documentation and updating a function name in the code.

Detailed summary

  • In apps/hubble/www/docs/docs/cli.md, the phrase "Commands must invoked" was corrected to "Commands must be invoked".
  • In packages/hub-nodejs/docs/Client.md, the function name geSSLHubRpcClient was updated to getSSLHubRpcClient.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

Copy link

changeset-bot bot commented Nov 28, 2024

⚠️ No Changeset found

Latest commit: 7d07caf

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

vercel bot commented Nov 28, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
hub-monorepo ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 28, 2024 6:45pm

@Danyylka
Copy link
Contributor Author

Danyylka commented Dec 6, 2024

Hi team! Could someone please review and merge my pull request? Let me know if any changes are needed. Thanks!

@cryptobenkei @mboyle @vrypan

@sds sds merged commit dc34dc8 into farcasterxyz:main Dec 7, 2024
3 checks passed
@sds sds added the t-docs Add or update documentation label Dec 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
t-docs Add or update documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants