feat: Store backups in separate top-level directory #2385
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why is this change needed?
This allows the backups directory to be mounted on a separate volume so that it doesn't take away from the main storage volume.
Merge Checklist
PR-Codex overview
This PR focuses on improving the backup functionality in the
RocksDB
implementation by changing the backup directory structure and enhancing logging.Detailed summary
main_backup_path
construction to place backups in a dedicatedbackup
directory, which is a sibling of themain_db_path
.