Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Store backups in separate top-level directory #2385

Merged
merged 1 commit into from
Oct 28, 2024
Merged

Conversation

sds
Copy link
Member

@sds sds commented Oct 28, 2024

Why is this change needed?

This allows the backups directory to be mounted on a separate volume so that it doesn't take away from the main storage volume.

Merge Checklist


PR-Codex overview

This PR focuses on improving the backup functionality in the RocksDB implementation by changing the backup directory structure and enhancing logging.

Detailed summary

  • Updated the log message format for creating a snapshot.
  • Changed the main_backup_path construction to place backups in a dedicated backup directory, which is a sibling of the main_db_path.
  • Adjusted the backup file naming format to include a timestamp.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

Copy link

vercel bot commented Oct 28, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
hub-monorepo ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 28, 2024 6:38am

Copy link

changeset-bot bot commented Oct 28, 2024

🦋 Changeset detected

Latest commit: 7c04e6f

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@farcaster/hubble Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

This allows the backups directory to be mounted on a separate volume so
that it doesn't take away from the main storage volume.
@sds sds force-pushed the sds/change-path branch from c035460 to 7c04e6f Compare October 28, 2024 06:37
@sds sds added the t-feat Add a new feature or protocol improvement label Oct 28, 2024
@sds sds merged commit 36847df into main Oct 28, 2024
8 checks passed
@sds sds deleted the sds/change-path branch October 28, 2024 15:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
t-feat Add a new feature or protocol improvement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant