bug fixes

changelog.md

@@ -1,5 +1,12 @@
 # Item Piles Changelog
 
+## Version 2.8.11
+
+- Tweaked styles of vaults and remove item backgrounds to support transparent images
+- Fixed item-based currencies to be excluded from the stackable property (currencies can always stack)
+- Fixed drag and dropping from other item piles into vaults not showing a proper item size preview
+- Fixed issue where larger items would sometimes be able to be dropped on top of other large items
+
 ## Version 2.8.10
 
 - Fixed non-stackable items with more than one quantity being added to item piles would incorrectly remove any extra quantity from the item

src/API/api.js

@@ -2090,7 +2090,7 @@ class API {
 	 *
 	 * @returns {Array<object>}                       An array of objects containing the data about each currency
 	 */
-	static getActorCurrencies(target, { getAll = false, secondary = True } = {}) {
+	static getActorCurrencies(target, { getAll = false, secondary = true } = {}) {
 		return PileUtilities.getActorCurrencies(target, { getAll, secondary });
 	}
 

src/applications/components/Grid/GridItem.svelte

@@ -216,8 +216,8 @@
 			dispatch("itemstopdrag", {
 				item,
 				outOfBounds: !active,
-				x: pageX - pointerOffset.internalLeft,
-				y: pageY - pointerOffset.internalTop,
+				x: pageX,
+				y: pageY,
 				gridX: finalTransform.x,
 				gridY: finalTransform.y,
 				splitting

src/applications/item-editor/item-editor.js

@@ -5,9 +5,11 @@ import { getActiveApps } from '../../helpers/helpers';
 export default class ItemEditor extends SvelteApplication {
 
 	constructor(item = false, options) {
+		let title = game.i18n.format("ITEM-PILES.Applications.ItemEditor.Title", { item_name: item.name })
+		if (options.extraTitle) title += options.extraTitle;
 		super({
 			id: `item-pile-item-editor-${item.id}-${randomID()}`,
-			title: game.i18n.format("ITEM-PILES.Applications.ItemEditor.Title", { item_name: item.name }),
+			title,
 			svelte: {
 				class: ItemEditorShell,
 				target: document.body,

src/applications/item-pile-inventory-app/ListEntry.svelte

@@ -2,6 +2,7 @@
 
 	import { fade } from 'svelte/transition';
 	import { localize } from '@typhonjs-fvtt/runtime/svelte/helper';
+	import CONSTANTS from "../../constants/constants.js";
 
 	export let store;
 	export let entry;
@@ -20,10 +21,12 @@
 	const editQuantities = store.editQuantities;
 
 	function dragStart(event) {
-		event.dataTransfer.setData('text/plain', JSON.stringify({
+		const data = {
 			type: "Item",
 			uuid: entry.item.uuid
-		}));
+		};
+		Hooks.callAll(CONSTANTS.HOOKS.DRAG_DOCUMENT, data)
+		event.dataTransfer.setData('text/plain', JSON.stringify(data));
 	}
 
 </script>

src/applications/vault-app/VaultItemEntry.svelte

@@ -36,7 +36,6 @@
   .grid-item {
     width: 100%;
     height: 100%;
-    background-color: rgb(56, 56, 56);
     transition: transform 2s, top 2s, left 2s;
     border-radius: 0.25rem;
     position: relative;

src/applications/vault-app/vault-shell.svelte

@@ -51,7 +51,7 @@
 	let element;
 
 	function onDragOverEvent(event) {
-		onDragOver(event.clientX, event.clientY);
+		onDragOver(event.clientX, event.clientY, true);
 	}
 
 	$: {
@@ -62,14 +62,14 @@
 		}
 	}
 
-	async function onDragOver(clientX, clientY) {
+	async function onDragOver(clientX, clientY, offset = false) {
 		const rect = element.getBoundingClientRect();
 		if (FloatingElement.id === application.id || !isCoordinateWithinPosition(clientX, clientY, rect)) {
 			return onDragLeave();
 		}
 		dragPositionStore.update(data => {
-			const x = (clientX - rect.left) - ((gridData.gridSize * data.w) / 2); //x position within the element.
-			const y = (clientY - rect.top) - ((gridData.gridSize * data.h) / 2);  //y position within the element.
+			const x = (clientX - rect.left) - (offset ? ((gridData.gridSize * data.w) / 2) : gridData.gridSize/2); //x position within the element.
+			const y = (clientY - rect.top) - (offset ? ((gridData.gridSize * data.w) / 2) : gridData.gridSize/2);  //y position within the element.
 			return {
 				...data,
 				...snapOnMove(x, y, { w: data.w, h: data.h }, { ...gridData }),
@@ -205,6 +205,10 @@
 			component: VaultItemEntry,
 			componentData: { entry: item }
 		})
+		Hooks.callAll(CONSTANTS.HOOKS.DRAG_DOCUMENT, {
+			type: "Item",
+			uuid: item.item.item.uuid
+		})
 	}
 
 	function itemStopDrag(event) {
@@ -242,6 +246,9 @@
 			if (hitApps[0].onDropData) {
 				return hitApps[0].onDropData(dropData);
 			}
+			if (hitApps[0]._handleDroppedEntry) {
+				return hitApps[0]._handleDroppedEntry(document.elementFromPoint(x, y), dropData);
+			}
 		}
 
 		const position = Helpers.getCanvasMouse().getLocalPosition(canvas.app.stage);