Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the redundant interface. #126

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Remove the redundant interface. #126

wants to merge 1 commit into from

Conversation

Kui-Liu
Copy link

@Kui-Liu Kui-Liu commented Oct 10, 2017

This class declares that it implements an interface Map which is also implemented by the superclass HashMap.
This is redundant because once a superclass implements an interface, all subclasses by default also implement this interface. It may point out that the inheritance hierarchy has changed since this class was created, and consideration should be given to the ownership of the interface's implementation.
http://findbugs.sourceforge.net/bugDescriptions.html#RI_REDUNDANT_INTERFACES

This class declares that it implements an interface Map which is also implemented by the superclass HashMap.
This is redundant because once a superclass implements an interface, all subclasses by default also implement this interface. It may point out that the inheritance hierarchy has changed since this class was created, and consideration should be given to the ownership of the interface's implementation.
http://findbugs.sourceforge.net/bugDescriptions.html#RI_REDUNDANT_INTERFACES
@RalleYTN
Copy link

Already fixed in my version of the library: https://github.com/RalleYTN/SimpleJSON
Also JSONObject doesn't extend HashMap but LinkedHashMap to ensure that the order of attributes doesn't get mixed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants