fix: Pre-empt accidentally leaking PII in logs #74
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows using the debug impls of our User structs without worrying too much about accidentally exposing PII, trying to start adhering to our logging policy.
Note that this means
external_user_id
should never contain PII, and as such we'll have to change the CSV source. An issue about this will be opened separately after we merge this - my suggestion would be to add a new column to the CSV sources so that we can simply give users non-sensitive IDs, but we will need to discuss the exact use cases in which we expect to be able to use the CSV source (can't mix it with non-CSV use cases if the external IDs don't match, but more on that on a future ticket).