Allow loading a Tileset without a Map #128
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ing directory, and reduced duplicate code in load()
The warning was: ISO C++20 considers use of overloaded operator '==' (with operand types 'tmx::Colour' and 'tmx::Colour') to be ambiguous despite there being a unique best viable function [-Wambiguous-reversed-operator]
|
Hi! Thanks for this. |
|
I'm actually not sure where the bar should be for testing 🤔 Anyway, no pressure, I don't mind using a forked version in my project. |
|
Sure! I'll give it a go when I have a moment - if nothing is broken then I'm sure it'll be OK to merge 😁 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Useful e.g. for generating maps in code.
Includes some cleanup commits.
Not super extensively tested, since I don't have a large project using this yet.