fix(k8smeta): introduce /proc scan to recover the pod uid of threads already spawned #517
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Andrea Terzolo <[email protected]>
poiana
added
kind/bug
Andreagit97
changed the title
Rules files suggestions |
Andreagit97
force-pushed
the
fix_k8smeta_proc_scan
branch
from
b4d2ab5 to
34b5fba
Compare
Rules files suggestions |
|
LGTM label has been added. Git tree hash: 7e40b508b8f3b049105fb9198e0119f088dba6c3
|
|
Thanks for the fix @Andreagit97! |
Andreagit97
force-pushed
the
fix_k8smeta_proc_scan
branch
from
34b5fba to
c5b99cc
Compare
Andreagit97
commented
Jul 24, 2024
Rules files suggestions |
Andreagit97
force-pushed
the
fix_k8smeta_proc_scan
branch
from
c5b99cc to
eb88343
Compare
Signed-off-by: Andrea Terzolo <[email protected]>
Andreagit97
force-pushed
the
fix_k8smeta_proc_scan
branch
from
eb88343 to
67d26fb
Compare
Andreagit97
commented
Jul 24, 2024
| @@ -77,7 +77,7 @@ limitations under the License. | |||
| // Generic plugin consts | |||
| ///////////////////////// | |||
| #define PLUGIN_NAME "k8smeta" | |||
| #define PLUGIN_VERSION "0.1.0" | |||
| #define PLUGIN_VERSION "0.1.1" | |||
There was a problem hiding this comment.
We bumped a patch version of the plugin
Rules files suggestions |
|
hey @Andreagit97, is this PR ready? |
Andreagit97
changed the title
|
yes! i removed the [WIP] |
|
LGTM label has been added. Git tree hash: dcd3c1e88753eab241d35ca59573f4d1a7de208a
|
leogr
approved these changes
Jul 24, 2024
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: alacuku, Andreagit97, leogr The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind bug
/kind feature
Any specific area of the project related to this PR?
/area plugins
What this PR does / why we need it:
This PR introduces a proc-scan feature in the k8smeta plugin init phase. We need this to collect the pod uid of threads already running when Falco and the k8smeta plugin are started.
Which issue(s) this PR fixes:
Fixes ##514
Special notes for your reviewer: