Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update handlers to match stats_prometheus.go #1110

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

rubensf
Copy link

@rubensf rubensf commented Jan 30, 2025

What type of PR is this?

Uncomment one (or more) /kind <> lines:

/kind bug

/kind cleanup

/kind design

/kind documentation

/kind failing-test

/kind feature

Any specific area of the project related to this PR?

Uncomment one (or more) /area <> lines:

/area build

/area config

/area outputs

/area tests

What this PR does / why we need it: #1051 updated stats_prometheus.go to replace . for _, but the code that then adds the labels to every instance did not update it, so instances where CUSTOM_FIELDS is set to use a key with .s leads to panics.

Which issue(s) this PR fixes: No Github Issue existing so far.

Fixes #

Special notes for your reviewer:

falcosecurity#1051 updated stats_prometheus.go to replace `.` for `_`, but the code that then adds the labels to every instance did not update it, so instances where CUSTOM_FIELDS is set to use a key with `.`s leads to panics.

Signed-off-by: Rubens Farias <[email protected]>
@poiana poiana added kind/bug Something isn't working dco-signoff: yes labels Jan 30, 2025
@poiana poiana requested review from fjogeleit and leogr January 30, 2025 22:21
@poiana
Copy link

poiana commented Jan 30, 2025

Welcome @rubensf! It looks like this is your first PR to falcosecurity/falcosidekick 🎉

@poiana poiana added the size/XS label Jan 30, 2025
@Issif Issif added this to the 2.31 milestone Jan 31, 2025
Issif
Issif previously approved these changes Jan 31, 2025
Copy link
Member

@Issif Issif left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice catch, thanks for you fix

@poiana
Copy link

poiana commented Jan 31, 2025

LGTM label has been added.

Git tree hash: 8a0afd3a68c4cd24adb37f6fbab0b6c9a26d2492

@Issif
Copy link
Member

Issif commented Jan 31, 2025

The CI fails:
image

@poiana
Copy link

poiana commented Jan 31, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: rubensf
Once this PR has been reviewed and has the lgtm label, please ask for approval from issif. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

1 similar comment
@poiana
Copy link

poiana commented Jan 31, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: rubensf
Once this PR has been reviewed and has the lgtm label, please ask for approval from issif. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@poiana
Copy link

poiana commented Jan 31, 2025

New changes are detected. LGTM label has been removed.

@poiana poiana removed the approved label Jan 31, 2025
@poiana
Copy link

poiana commented Jan 31, 2025

Thanks for your pull request. Before we can look at it, you'll need to add a 'DCO signoff' to your commits.

📝 Please follow instructions in the contributing guide to update your commits with the DCO

Full details of the Developer Certificate of Origin can be found at developercertificate.org.

The list of commits missing DCO signoff:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: In progress
Development

Successfully merging this pull request may close these issues.

3 participants