-
Notifications
You must be signed in to change notification settings - Fork 185
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update handlers to match stats_prometheus.go #1110
base: master
Are you sure you want to change the base?
Conversation
falcosecurity#1051 updated stats_prometheus.go to replace `.` for `_`, but the code that then adds the labels to every instance did not update it, so instances where CUSTOM_FIELDS is set to use a key with `.`s leads to panics. Signed-off-by: Rubens Farias <[email protected]>
Welcome @rubensf! It looks like this is your first PR to falcosecurity/falcosidekick 🎉 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice catch, thanks for you fix
LGTM label has been added. Git tree hash: 8a0afd3a68c4cd24adb37f6fbab0b6c9a26d2492
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: rubensf The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
1 similar comment
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: rubensf The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
New changes are detected. LGTM label has been removed. |
Thanks for your pull request. Before we can look at it, you'll need to add a 'DCO signoff' to your commits. 📝 Please follow instructions in the contributing guide to update your commits with the DCO Full details of the Developer Certificate of Origin can be found at developercertificate.org. The list of commits missing DCO signoff:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
What type of PR is this?
/kind bug
Any specific area of the project related to this PR?
What this PR does / why we need it: #1051 updated stats_prometheus.go to replace
.
for_
, but the code that then adds the labels to every instance did not update it, so instances where CUSTOM_FIELDS is set to use a key with.
s leads to panics.Which issue(s) this PR fixes: No Github Issue existing so far.
Fixes #
Special notes for your reviewer: