[Elasticsearch] Fix the missing configuration environment variables propagation #1013
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ropagation Signed-off-by: Aleksandr Maus <[email protected]>
Issif
requested changes
Oct 4, 2024
docs/outputs/elasticsearch.md
Outdated
| | `elasticsearch.flattenfields` | `ELASTICSEARCH_FLATTENFIELDS` | `false` | Replace . by _ to avoid mapping conflicts, force to true if `createindextemplate=true` | | ||
| | `elasticsearch.createindextemplate` | `ELASTICSEARCH_CREATEINDEXTEMPLATE` | `false` | Create an index template | | ||
| | `elasticsearch.numberofshards` | `ELASTICSEARCH_NUMBEROFSHARDS` | `3` | Number of shards set by the index template | | ||
| | `elasticsearch.numberofreplicas` | `ELASTICSEARCH_REPLICAS` | `3` | Number of replicas set by the index template | |
There was a problem hiding this comment.
Suggested change
| | `elasticsearch.numberofreplicas` | `ELASTICSEARCH_REPLICAS` | `3` | Number of replicas set by the index template | | |
| | `elasticsearch.numberofreplicas` | `ELASTICSEARCH_NUMEROFREPLICAS` | `3` | Number of replicas set by the index template | |
There was a problem hiding this comment.
still a typo :-) corrected.
Signed-off-by: Aleksandr Maus <[email protected]>
aleksmaus
force-pushed
the
fix/elasticseach_env_configuration
branch
from
6722cdd to
58ea997
Compare
Issif
approved these changes
Oct 4, 2024
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: aleksmaus, Issif The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
LGTM label has been added. Git tree hash: 3801ec9f44e5d4d0fe5593e39928a481874cca98
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind bug
Any specific area of the project related to this PR?
/area outputs
What this PR does / why we need it:
This PR fixes missing, some old and some recently introduced, environment variables propagation into Falco Sidekick configuration.
Before this change, not all the configuration options that were provided via the environment variables were propagated into Falco Sidekick configuration.
For example something like this:
fails to set the custom headers.