Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(userspace/falco): use correct filtercheck_field_info. #3426

Merged
merged 1 commit into from
Dec 6, 2024

Conversation

FedeDP
Copy link
Contributor

@FedeDP FedeDP commented Dec 6, 2024

What type of PR is this?

/kind bug

Any specific area of the project related to this PR?

/area engine

What this PR does / why we need it:

Fix on top of #3388: filter_check_info->m_name is the global name of the list of checks, eg: container (plugin).
Instead, we need to loop on each field info.

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

NONE

@FedeDP
Copy link
Contributor Author

FedeDP commented Dec 6, 2024

/milestone 0.40.0

@poiana poiana added this to the 0.40.0 milestone Dec 6, 2024
@poiana poiana added the size/S label Dec 6, 2024
Copy link
Member

@Andreagit97 Andreagit97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@poiana
Copy link
Contributor

poiana commented Dec 6, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Andreagit97, FedeDP

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@poiana poiana merged commit f8feea6 into master Dec 6, 2024
33 of 34 checks passed
@poiana poiana deleted the fix/use_correct_field_info branch December 6, 2024 12:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

4 participants