Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make enable()/disable() virtual so they can be overridden #3375

Merged
merged 1 commit into from
Oct 16, 2024

Conversation

mstemm
Copy link
Contributor

@mstemm mstemm commented Oct 9, 2024

Subclasses might want to also see when rules are enabled/disabled.

What type of PR is this?

Uncomment one (or more) /kind <> lines:

/kind bug

/kind cleanup

/kind design

/kind documentation

/kind failing-test

/kind feature

/kind release

Any specific area of the project related to this PR?

Uncomment one (or more) /area <> lines:

/area build

/area engine

/area tests

/area proposals

/area CI

What this PR does / why we need it:

Make enable()/disable() virtual so they can be overridden
Subclasses might want to also see when rules are enabled/disabled.

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

NONE

Subclasses might want to also see when rules are enabled/disabled.

Signed-off-by: Mark Stemm <[email protected]>
Copy link

github-actions bot commented Oct 9, 2024

This PR may bring feature or behavior changes in the Falco engine and may require the engine version to be bumped.

Please double check userspace/engine/falco_engine_version.h file. See versioning for FALCO_ENGINE_VERSION.

/hold

Copy link
Contributor

@FedeDP FedeDP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@poiana
Copy link
Contributor

poiana commented Oct 16, 2024

LGTM label has been added.

Git tree hash: 95aacde8050814dd76de0cd58a6ce2b8d1e0af00

@FedeDP
Copy link
Contributor

FedeDP commented Oct 16, 2024

/milestone 0.40.0

@poiana poiana added this to the 0.40.0 milestone Oct 16, 2024
@poiana
Copy link
Contributor

poiana commented Oct 16, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: FedeDP, mstemm

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@leogr
Copy link
Member

leogr commented Oct 16, 2024

This PR may bring feature or behavior changes in the Falco engine and may require the engine version to be bumped.

Please double check userspace/engine/falco_engine_version.h file. See versioning for FALCO_ENGINE_VERSION.

/hold

False positive
/unhold

@poiana poiana merged commit e99b11e into master Oct 16, 2024
36 checks passed
@poiana poiana deleted the make-indexable-ruleset-enable-disable-virtual branch October 16, 2024 10:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

4 participants