chore: scaffolding for enabling code formatting #3321
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@falcosecurity/falco-maintainers let me know what you think about this |
Andreagit97
commented
Sep 11, 2024
There was a problem hiding this comment.
Do we have some files to add here? @FedeDP
Signed-off-by: Andrea Terzolo <[email protected]>
Andreagit97
force-pushed
the
introduce_format
branch
from
f284386 to
81c7075
Compare
|
+1 from me! |
|
+1 from me too! |
|
+1 |
|
If the maintainers are all on board, then it is a +1 from me too. |
|
/milestone 0.39.0 |
leogr
approved these changes
Sep 11, 2024
|
LGTM label has been added. Git tree hash: 78724022e263a161ab8df9bb5d91c768e9141aba
|
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Andreagit97, FedeDP The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind cleanup
/kind feature
Any specific area of the project related to this PR?
/area build
/area CI
What this PR does / why we need it:
This is the dual of falcosecurity/libs#2038 for libs if we want to apply the format also here! It would be great to do it before detaching the release branch
Which issue(s) this PR fixes:
Special notes for your reviewer:
Does this PR introduce a user-facing change?: