Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(userspace): align falco to gen-event class family deprecation #3051

Merged
merged 4 commits into from
Feb 6, 2024

Conversation

jasondellaluce
Copy link
Contributor

What type of PR is this?

/kind cleanup

/kind design

Any specific area of the project related to this PR?

/area engine

What this PR does / why we need it:

This follows up the changes of falcosecurity/libs#1659. The libs & drivers deps are bumped and the codebase updated accordingly.

Which issue(s) this PR fixes:

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

NONE

Copy link

github-actions bot commented Feb 1, 2024

This PR may bring feature or behavior changes in the Falco engine and may require the engine version to be bumped.

Please double check userspace/engine/falco_engine_version.h file. See versioning for FALCO_ENGINE_VERSION.

/hold

@jasondellaluce
Copy link
Contributor Author

/unhold

@jasondellaluce jasondellaluce force-pushed the refactor/bump-libs-gen-event-removal branch from 6a5c768 to 1171577 Compare February 5, 2024 12:02
Copy link
Contributor

@FedeDP FedeDP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@poiana
Copy link
Contributor

poiana commented Feb 6, 2024

LGTM label has been added.

Git tree hash: 6cf5698f20d165a1681bfd665b042520249d5de8

@FedeDP
Copy link
Contributor

FedeDP commented Feb 6, 2024

/milestone 0.38.0

@poiana poiana added this to the 0.38.0 milestone Feb 6, 2024
@poiana
Copy link
Contributor

poiana commented Feb 6, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: FedeDP, jasondellaluce, leogr

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [FedeDP,jasondellaluce,leogr]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@poiana poiana merged commit 039069d into master Feb 6, 2024
29 checks passed
@poiana poiana deleted the refactor/bump-libs-gen-event-removal branch February 6, 2024 09:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

4 participants