Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(dist): only detect falcon* as packages #2385

Merged
merged 4 commits into from
Oct 22, 2024

Conversation

vytas7
Copy link
Member

@vytas7 vytas7 commented Oct 22, 2024

Fixes #2384.

@vytas7 vytas7 requested review from kgriffs and CaselIT October 22, 2024 17:18
Copy link

codecov bot commented Oct 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (1bfb819) to head (4a60926).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff            @@
##            master     #2385   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           64        64           
  Lines         7725      7725           
  Branches      1071      1071           
=========================================
  Hits          7725      7725           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@CaselIT CaselIT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we could release 4.0.1 once this is merged.

Or do you prefer waiting til the end of the week?

@vytas7
Copy link
Member Author

vytas7 commented Oct 22, 2024

No, :shipit: today

@vytas7 vytas7 merged commit c5c1247 into falconry:master Oct 22, 2024
31 checks passed
vytas7 added a commit that referenced this pull request Oct 22, 2024
* fix(dist): only detect `falcon*` as packages

* fix: fix test-dist action

* fix(workflows): one more fix for test-dist...

* chore: run the new gate only on master merge
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Falcon 4.0.0 adds possibly unintended directories when installed
2 participants