Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: prepare 4.0.0b3 #2367

Merged
merged 1 commit into from
Oct 10, 2024
Merged

chore: prepare 4.0.0b3 #2367

merged 1 commit into from
Oct 10, 2024

Conversation

vytas7
Copy link
Member

@vytas7 vytas7 commented Oct 10, 2024

No description provided.

@vytas7 vytas7 requested review from kgriffs and CaselIT October 10, 2024 19:09
Copy link

codecov bot commented Oct 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (db33c9c) to head (d5e1769).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff            @@
##            master     #2367   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           64        64           
  Lines         7725      7725           
  Branches      1071      1071           
=========================================
  Hits          7725      7725           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@CaselIT CaselIT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

don't we render the newsfragment for the fix we did?

@vytas7
Copy link
Member Author

vytas7 commented Oct 10, 2024

don't we render the newsfragment for the fix we did?

No, we don't even have the placeholder left, we have rendered out everything already.

I have inserted it by hand: https://falcon.readthedocs.io/en/latest/changes/4.0.0.html#fixed

@CaselIT
Copy link
Member

CaselIT commented Oct 10, 2024

ok then

@vytas7 vytas7 merged commit 2556dbe into falconry:master Oct 10, 2024
31 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants